-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci: add import profiler check across monorepo #17657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6d60f59
ci: add import profiler check across monorepo
hebaalazzeh da118aa
ci: allow prerelease for python 3.15 in setup-python
hebaalazzeh 5eab435
chore: propagate import_profile nox session across all packages and g…
hebaalazzeh 8ccfb28
fix(ci): gracefully skip import_profile session if profiler script mi…
hebaalazzeh a0c075f
style(ci): reformat noxfile with black to fix lint errors
hebaalazzeh a7d2363
chore: revert google-crc32c noxfile modification to bypass broken kok…
hebaalazzeh 68a0bdf
fix(ci): fix bazel integration tests and lint formatting
hebaalazzeh 42dd64a
chore: revert gapic-generator template and noxfile changes in packages
hebaalazzeh a6491b5
ci: run import_profile without nox templates
hebaalazzeh 9472ab6
address PR comments for import profiler CI
hebaalazzeh 705b188
fix: update goldens for gapic-generator integration tests
hebaalazzeh 885de7f
feat: implement dynamic import profile diff check against baseline
hebaalazzeh a2bd6ec
refactor: simplify CI without gapic-generator template changes and fi…
hebaalazzeh a77dc18
chore: remove nox installation from import profiler job
hebaalazzeh 8a2d75b
chore: temporary commit to trigger profiler
hebaalazzeh 9732c4e
chore: temporarily force profiler to run on all packages for benchmar…
hebaalazzeh df592fe
fix: resolve profiler baseline args and improve failure logs
hebaalazzeh b87f403
fix: restore dynamic label check for import profiler BUILD_TYPE
hebaalazzeh 483e44b
chore: temporarily force profiler to run on all packages again for be…
hebaalazzeh 943133d
fix: restore dynamic label check for import profiler BUILD_TYPE
hebaalazzeh 8aff62c
fix: revert dummy __init__ changes to fix OwlBot Post Processor
hebaalazzeh ff77903
chore: address reviewer feedback on iterations, bytecode caching, and…
hebaalazzeh 09932d5
chore: address omair's feedback on timeouts, baseline logic, threshol…
hebaalazzeh c05ad7d
chore: remove dynamic all_packages label logic to prevent unintention…
hebaalazzeh 80ed579
Update scripts/import_profiler/profiler.py
hebaalazzeh e06bd2d
chore: add progress logs to profiler script to prevent appearing stuck
hebaalazzeh ee1645b
chore: address reviewer feedback (pathlib nit and median logic)
hebaalazzeh 6a972d8
chore: dummy commit to trigger profiler CI on compute and kms packages
hebaalazzeh 1c13c8c
chore: bypass absolute import fail threshold if baseline also exceeds it
hebaalazzeh 85f4a4f
Update scripts/import_profiler/profiler.py
hebaalazzeh b100f3a
Update scripts/import_profiler/profiler.py
hebaalazzeh c6a0a71
chore: address CI feedback on git worktree, bytecode cleanup, and imp…
hebaalazzeh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: import-profiler | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - preview | ||
| # Trigger workflow on GitHub merge queue events | ||
| merge_group: | ||
| types: [checks_requested] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| import-profile: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 2 | ||
| - name: Setup Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.15" | ||
| allow-prereleases: true | ||
| - name: Install nox | ||
| run: | | ||
| python -m pip install --upgrade setuptools pip wheel | ||
| python -m pip install nox | ||
|
chalmerlowe marked this conversation as resolved.
Outdated
|
||
| - name: Run import profiler | ||
| env: | ||
| BUILD_TYPE: presubmit | ||
| TARGET_BRANCH: ${{ github.base_ref || github.event.merge_group.base_ref }} | ||
| TEST_TYPE: import_profile | ||
| PY_VERSION: "3.15" | ||
| run: | | ||
| ci/run_conditional_tests.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.