Skip to content

fix(ci): install setuptools in temporary virtualenv for import profile - #17714

Merged
hebaalazzeh merged 1 commit into
mainfrom
fix-import-profiler-ci
Jul 14, 2026
Merged

fix(ci): install setuptools in temporary virtualenv for import profile#17714
hebaalazzeh merged 1 commit into
mainfrom
fix-import-profiler-ci

Conversation

@hebaalazzeh

@hebaalazzeh hebaalazzeh commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

The import-profile CI workflow fails on Python 3.15 with:

ModuleNotFoundError: No module named 'google.cloud.api'. Did you mean: 'google.cloud.location'?

This PR installs setuptools inside the temporary .venv-profiler virtualenv created for profiling. This ensures the profiler's namespace package resolution logic works correctly on newer Python versions (3.12+) where setuptools is no longer installed by default.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ci/run_single_test.sh script to upgrade pip and setuptools within the temporary virtual environment created for the import profile test. There are no review comments, and I have no feedback to provide.

@hebaalazzeh
hebaalazzeh marked this pull request as ready for review July 14, 2026 21:30
@hebaalazzeh
hebaalazzeh requested a review from a team as a code owner July 14, 2026 21:30
@hebaalazzeh
hebaalazzeh enabled auto-merge (squash) July 14, 2026 21:31
@hebaalazzeh
hebaalazzeh merged commit b2f7cb0 into main Jul 14, 2026
28 checks passed
@hebaalazzeh
hebaalazzeh deleted the fix-import-profiler-ci branch July 14, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants