Skip to content

test(spanner): add pytest-asyncio to samples test requirements - #17731

Merged
sakthivelmanii merged 1 commit into
mainfrom
fix-spanner-samples-pytest-asyncio
Jul 16, 2026
Merged

test(spanner): add pytest-asyncio to samples test requirements#17731
sakthivelmanii merged 1 commit into
mainfrom
fix-spanner-samples-pytest-asyncio

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

The asynchronous snippets test in samples/samples failed because the pytest-asyncio plugin was missing from the test environment. Added the required plugin to requirements-test.txt for samples.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

The asynchronous snippets test in samples/samples failed because the pytest-asyncio plugin was missing from the test environment. Added the required plugin to requirements-test.txt for samples.
@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner July 16, 2026 06:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the pytest-asyncio dependency (version 0.25.1) to the test requirements file (requirements-test.txt) for the Google Cloud Spanner samples. There are no review comments, and I have no feedback to provide.

@sakthivelmanii
sakthivelmanii merged commit a2b4096 into main Jul 16, 2026
40 checks passed
@sakthivelmanii
sakthivelmanii deleted the fix-spanner-samples-pytest-asyncio branch July 16, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants