Skip to content

fix(ci): support python 3.15 builds and make import profiler warning-only - #17776

Closed
hebaalazzeh wants to merge 1 commit into
mainfrom
fix/import-profiler-3.15-compat
Closed

fix(ci): support python 3.15 builds and make import profiler warning-only#17776
hebaalazzeh wants to merge 1 commit into
mainfrom
fix/import-profiler-3.15-compat

Conversation

@hebaalazzeh

Copy link
Copy Markdown
Contributor

This PR resolves build failures on Python 3.15 and updates the import profiler checks to log warning messages instead of failing GHA checks, preventing any developer workflow blockages.

Key Changes

  1. Python 3.15 Compatibility:
    • Exported PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 inside the temporary virtual environment block in run_single_test.sh. This ensures Rust-based transitive dependencies (like libcst used by bigframes) build successfully on Python 3.15.
  2. Warning-Only Threshold Checks:
    • Increased the absolute failure threshold to 20000ms.
    • Updated both regression and absolute threshold checks to output strong WARNING messages instead of failing the check (the script will exit with code 0). This ensures the CI check status remains green while still providing performance regression visibility in the logs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the import profiler and CI configuration to make import time regressions non-blocking. Specifically, it increases the failure threshold in ci/run_single_test.sh and modifies scripts/import_profiler/profiler.py to log warnings instead of failures and avoid setting a non-zero exit code. The reviewer suggests updating the warning messages in profiler.py to remove misleading references to "bypassing failure" since failures are no longer triggered.

Comment thread scripts/import_profiler/profiler.py Outdated
@hebaalazzeh hebaalazzeh self-assigned this Jul 20, 2026
@hebaalazzeh
hebaalazzeh marked this pull request as ready for review July 20, 2026 16:09
@hebaalazzeh
hebaalazzeh requested a review from a team as a code owner July 20, 2026 16:09
@hebaalazzeh
hebaalazzeh force-pushed the fix/import-profiler-3.15-compat branch from 63ef225 to ec047f5 Compare July 20, 2026 16:10
@hebaalazzeh
hebaalazzeh deleted the fix/import-profiler-3.15-compat branch July 20, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant