fix(ci): support python 3.15 builds and make import profiler warning-only - #17776
Closed
hebaalazzeh wants to merge 1 commit into
Closed
fix(ci): support python 3.15 builds and make import profiler warning-only#17776hebaalazzeh wants to merge 1 commit into
hebaalazzeh wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the import profiler and CI configuration to make import time regressions non-blocking. Specifically, it increases the failure threshold in ci/run_single_test.sh and modifies scripts/import_profiler/profiler.py to log warnings instead of failures and avoid setting a non-zero exit code. The reviewer suggests updating the warning messages in profiler.py to remove misleading references to "bypassing failure" since failures are no longer triggered.
hebaalazzeh
force-pushed
the
fix/import-profiler-3.15-compat
branch
from
July 20, 2026 16:10
63ef225 to
ec047f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves build failures on Python 3.15 and updates the import profiler checks to log warning messages instead of failing GHA checks, preventing any developer workflow blockages.
Key Changes
PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1inside the temporary virtual environment block inrun_single_test.sh. This ensures Rust-based transitive dependencies (likelibcstused bybigframes) build successfully on Python 3.15.20000ms.WARNINGmessages instead of failing the check (the script will exit with code0). This ensures the CI check status remains green while still providing performance regression visibility in the logs.