Skip to content

fix(ci): skip import profiler on python version mismatch during install #17784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hebaalazzeh wants to merge 1 commit into from
Closed

fix(ci): skip import profiler on python version mismatch during install #17784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions ci/run_single_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,26 @@ case ${TEST_TYPE} in
echo "Could not find baseline commit for ${TARGET_BRANCH:-main}. Skipping baseline generation."
fi
fi
# Run pip install and capture output to inspect for python compatibility issues
pip_output=$(pip install -e . 2>&1)
pip_retval=$?

pip install -e .

if [ ${pip_retval} -ne 0 ]; then
echo "${pip_output}"
if echo "${pip_output}" | grep -q "requires a different Python"; then
echo "WARNING: Package ${PACKAGE_NAME} is not compatible with Python ${PY_VERSION}. Skipping import profiler."
deactivate
rm -rf .venv-profiler
rm -rf "${PROFILER_TEMP_DIR}"
exit 0
else
echo "ERROR: Failed to install package ${PACKAGE_NAME}."
deactivate
rm -rf .venv-profiler
rm -rf "${PROFILER_TEMP_DIR}"
exit ${pip_retval}
fi
fi
Comment on lines +142 to +157

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The cleanup logic (deactivate and removing temporary directories) is duplicated in both branches of the conditional check. This can be simplified by performing the cleanup immediately after printing the pip output, before checking the specific error message.

Suggested change
if [ ${pip_retval} -ne 0 ]; then
echo "${pip_output}"
if echo "${pip_output}" | grep -q "requires a different Python"; then
echo "WARNING: Package ${PACKAGE_NAME} is not compatible with Python ${PY_VERSION}. Skipping import profiler."
deactivate
rm -rf .venv-profiler
rm -rf "${PROFILER_TEMP_DIR}"
exit 0
else
echo "ERROR: Failed to install package ${PACKAGE_NAME}."
deactivate
rm -rf .venv-profiler
rm -rf "${PROFILER_TEMP_DIR}"
exit ${pip_retval}
fi
fi
if [ ${pip_retval} -ne 0 ]; then
echo "${pip_output}"
deactivate
rm -rf .venv-profiler
rm -rf "${PROFILER_TEMP_DIR}"
if echo "${pip_output}" | grep -q "requires a different Python"; then
echo "WARNING: Package ${PACKAGE_NAME} is not compatible with Python ${PY_VERSION}. Skipping import profiler."
exit 0
else
echo "ERROR: Failed to install package ${PACKAGE_NAME}."
exit ${pip_retval}
fi
fi

if [ -f "${BASELINE_CSV}" ]; then
python ${PROFILER_SCRIPT} --package ${PACKAGE_NAME} --iterations 11 --fail-threshold 5000 --diff-baseline "${BASELINE_CSV}" --diff-threshold 100
else
Expand Down
Loading