test(api-core): use re.fullmatch for strict UUID validation - #17797
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the unit test test_setup_request_id in packages/google-api-core/tests/unit/gapic/test_requests.py to use re.fullmatch instead of re.match when validating UUIDs against UUID_REGEX. There are no review comments, and I have no feedback to provide.
hebaalazzeh
force-pushed
the
fix/uuid-validation-strict
branch
from
July 20, 2026 23:17
80f8ef2 to
1e7d8d4
Compare
daniel-sanche
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses code review feedback regarding test assertion strictness:
re.matchtore.fullmatchfor strict UUID validation intest_requests.py, ensuring trailing characters are not accepted.