Skip to content

test(api-core): use re.fullmatch for strict UUID validation #17797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hebaalazzeh merged 2 commits into from
Jul 20, 2026
+15 −1
Merged

test(api-core): use re.fullmatch for strict UUID validation #17797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b62e121
test(api-core): use re.fullmatch for strict UUID validation
hebaalazzeh Jul 20, 2026
1e7d8d4
test(api-core): add test case verifying UUID_REGEX strictness
hebaalazzeh Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/google-api-core/tests/unit/gapic/test_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,20 @@ def test_setup_request_id(request_obj, is_proto3_optional, expected):
)

if expected == "uuid":
assert re.match(UUID_REGEX, value)
assert re.fullmatch(UUID_REGEX, value)
else:
assert value == expected


def test_setup_request_id_assertion_strictness(mocker):
# Mock uuid.uuid4 to return a UUID with trailing characters
mock_uuid = mocker.patch("uuid.uuid4")
mock_uuid.return_value.__str__.return_value = (
"12345678-1234-4123-8123-123456789012-extra"
)

# We expect test_setup_request_id to fail (raise AssertionError) because the UUID is invalid.
# If test_setup_request_id uses re.fullmatch, it will fail (raise AssertionError), so pytest.raises passes.
# If test_setup_request_id uses re.match, it will NOT fail, so pytest.raises fails!
with pytest.raises(AssertionError):
test_setup_request_id(MockRequest(), is_proto3_optional=True, expected="uuid")
Loading