test(bigquery): add debug info to socket leak test - #17802
Merged
Conversation
chalmerlowe
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a try-except block to capture and log detailed socket connection debug information when the test_dbapi_connection_does_not_leak_sockets test fails. The review feedback correctly identifies that current_process.net_connections() is not a valid method and will raise an AttributeError, masking the assertion failure, and suggests using current_process.connections() instead.
hebaalazzeh
marked this pull request as ready for review
July 21, 2026 17:41
hebaalazzeh
requested review from
hebaalazzeh and
sycai
and removed request for
a team
July 21, 2026 17:41
hebaalazzeh
approved these changes
Jul 21, 2026
daniel-sanche
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The system test
test_dbapi_connection_does_not_leak_socketshas been failing intermittently with minor socket count discrepancies (e.g., 7 instead of 6). Previous attempts to fix this have not fully eliminated the flakiness, likely due to non-deterministic garbage collection or Operating System cleanup delays. Without knowing the exact state of these "leaked" sockets (e.g.,TIME_WAITvsCLOSE_WAIT), it is difficult to determine if this is a real resource leak in the application or just OS noise.Solution
This PR wraps the socket count assertion in a
try...except AssertionErrorblock. If the assertion fails, it captures the status, local address, and remote address of all active network connections for the current process and appends this information to the failure message.Notes to Reviewers
TIME_WAIT) and real application leaks (CLOSE_WAITorESTABLISHED) in future CI/CD runs.