Skip to content

chore: allow bigframes tests to use compute engine credentials - #17824

Merged
tswast merged 1 commit into
mainfrom
b517198791-gob-nox-credentials
Jul 22, 2026
Merged

chore: allow bigframes tests to use compute engine credentials#17824
tswast merged 1 commit into
mainfrom
b517198791-gob-nox-credentials

Conversation

@tswast

@tswast tswast commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This is in response to internal issue b/537733439 where the tests are being skipped on the internal test cluster
🦕

This is in response to internal issue b/537733439 where the tests are being skipped on the internal test cluster
@tswast
tswast requested review from a team as code owners July 22, 2026 15:38
@tswast
tswast requested review from shuoweil and removed request for a team July 22, 2026 15:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the checks for the GOOGLE_APPLICATION_CREDENTIALS environment variable in the run_system and prerelease session functions within packages/bigframes/noxfile.py. This prevents the sessions from being skipped when the environment variable is not explicitly set. There are no review comments, and I have no feedback to provide.

@tswast
tswast requested a review from sycai July 22, 2026 15:40
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2026
@tswast

tswast commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

import-profiler failure:

Collecting pyproj>=3.5.0 (from geopandas>=0.12.2->bigframes==2.46.0)
  Downloading pyproj-3.7.2.tar.gz (226 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      proj executable not found. Please set the PROJ_DIR variable. For more information see: https://pyproj4.github.io/pyproj/stable/installation.html
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed to build 'pyproj' when getting requirements to build wheel
Error in worker process:
Traceback (most recent call last):
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 447, in <module>
    run_worker(target_module)
    ~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 57, in run_worker
    importlib.import_module(target_module)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.15.0-beta.4/x64/lib/python3.15/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1381, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1346, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1298, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'bigframes'

Profiling start... Running 11 cold-start iterations for bigframes.
Sweeping directory to delete __pycache__ and force bytecode recompilation...
Cleared 0 cached bytecode locations.
CPU Pinning enabled: Pinning processes to core 0 using taskset.
Traceback (most recent call last):
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 458, in <module>
    sys.exit(run_master(args.iterations, target_module, args.cpu, args.csv, not args.keep_pycache, args.fail_threshold, args.diff_baseline, args.diff_threshold))
             ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 210, in run_master
    raise e
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 191, in run_master
    data = _run_worker_and_parse(cmd)
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 108, in _run_worker_and_parse
    result = subprocess.run(cmd, capture_output=True, text=True, check=True)
  File "/opt/hostedtoolcache/Python/3.15.0-beta.4/x64/lib/python3.15/subprocess.py", line 692, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['taskset', '-c', '0', '/home/runner/work/google-cloud-python/google-cloud-python/packages/bigframes/.venv-profiler/bin/python', '-B', '/tmp/tmp.z1QMiFbCcE/profiler.py', '--worker', '--module=bigframes']' returned non-zero exit status 1.
Obtaining file:///home/runner/work/google-cloud-python/google-cloud-python/packages/bigframes
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Checking if build backend supports build_editable: started
  Checking if build backend supports build_editable: finished with status 'done'
  Getting requirements to build editable: started
  Getting requirements to build editable: finished with status 'done'
  Preparing editable metadata (pyproject.toml): started
  Preparing editable metadata (pyproject.toml): finished with status 'done'

TBH, I don't know that the purpose of that job is, and it's not marked as required, so maybe safe to ignore?

@shuoweil

Copy link
Copy Markdown
Contributor

import-profiler failure:

Collecting pyproj>=3.5.0 (from geopandas>=0.12.2->bigframes==2.46.0)
  Downloading pyproj-3.7.2.tar.gz (226 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      proj executable not found. Please set the PROJ_DIR variable. For more information see: https://pyproj4.github.io/pyproj/stable/installation.html
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed to build 'pyproj' when getting requirements to build wheel
Error in worker process:
Traceback (most recent call last):
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 447, in <module>
    run_worker(target_module)
    ~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 57, in run_worker
    importlib.import_module(target_module)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.15.0-beta.4/x64/lib/python3.15/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1381, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1346, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1298, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'bigframes'

Profiling start... Running 11 cold-start iterations for bigframes.
Sweeping directory to delete __pycache__ and force bytecode recompilation...
Cleared 0 cached bytecode locations.
CPU Pinning enabled: Pinning processes to core 0 using taskset.
Traceback (most recent call last):
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 458, in <module>
    sys.exit(run_master(args.iterations, target_module, args.cpu, args.csv, not args.keep_pycache, args.fail_threshold, args.diff_baseline, args.diff_threshold))
             ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 210, in run_master
    raise e
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 191, in run_master
    data = _run_worker_and_parse(cmd)
  File "/tmp/tmp.z1QMiFbCcE/profiler.py", line 108, in _run_worker_and_parse
    result = subprocess.run(cmd, capture_output=True, text=True, check=True)
  File "/opt/hostedtoolcache/Python/3.15.0-beta.4/x64/lib/python3.15/subprocess.py", line 692, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['taskset', '-c', '0', '/home/runner/work/google-cloud-python/google-cloud-python/packages/bigframes/.venv-profiler/bin/python', '-B', '/tmp/tmp.z1QMiFbCcE/profiler.py', '--worker', '--module=bigframes']' returned non-zero exit status 1.
Obtaining file:///home/runner/work/google-cloud-python/google-cloud-python/packages/bigframes
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Checking if build backend supports build_editable: started
  Checking if build backend supports build_editable: finished with status 'done'
  Getting requirements to build editable: started
  Getting requirements to build editable: finished with status 'done'
  Preparing editable metadata (pyproject.toml): started
  Preparing editable metadata (pyproject.toml): finished with status 'done'

TBH, I don't know that the purpose of that job is, and it's not marked as required, so maybe safe to ignore?

HI @tswast Our sister team checked in this new test, but they did not test on python 3.15. I have filed the bug to them to fix it. Please ignore these failures until they fix the bug.

@tswast
tswast merged commit aeaeb49 into main Jul 22, 2026
38 of 39 checks passed
@tswast
tswast deleted the b517198791-gob-nox-credentials branch July 22, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants