From b0cdfcb01da5191357d5c903171e91b8b3f1683c Mon Sep 17 00:00:00 2001 From: ohmayr Date: Thu, 23 Jul 2026 16:13:03 +0000 Subject: [PATCH 1/3] chore(generator): update pqc system tests to use grpcio 1.83.0 --- packages/gapic-generator/noxfile.py | 4 +--- packages/gapic-generator/tests/system/test_pqc.py | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/gapic-generator/noxfile.py b/packages/gapic-generator/noxfile.py index 9d3d9fefaa8d..1180b3fd294e 100644 --- a/packages/gapic-generator/noxfile.py +++ b/packages/gapic-generator/noxfile.py @@ -498,9 +498,7 @@ def showcase_pqc( """Run the Showcase PQC verification test suite against grpcio 1.83+ over standard TLS.""" with showcase_library(session, templates=templates, other_opts=other_opts): session.install("pytest", "pytest-asyncio") - # TODO(https://github.com/googleapis/google-cloud-python/issues/17751): - # Update the version below to `1.83.0` once released, and remove `--pre`. - session.install("--pre", "--upgrade", "grpcio>=1.83.0rc0", "grpcio-status>=1.83.0rc0") + session.install("--pre", "--upgrade", "grpcio>=1.83.0", "grpcio-status>=1.83.0") session.run("py.test", "--quiet", "--tls", *(session.posargs or ["tests/system/test_pqc.py"]), env=env) diff --git a/packages/gapic-generator/tests/system/test_pqc.py b/packages/gapic-generator/tests/system/test_pqc.py index 2d694b6528f0..855fec0f341e 100644 --- a/packages/gapic-generator/tests/system/test_pqc.py +++ b/packages/gapic-generator/tests/system/test_pqc.py @@ -45,7 +45,7 @@ def test_pqc_grpc(intercepted_echo_grpc): """Verifies that the gRPC client library negotiates post-quantum MLKEM with Showcase server.""" # TODO(https://github.com/googleapis/google-cloud-python/issues/17752): # Remove this check once grpcio >= 1.83.0 is enforced across all client libraries. - if Version(grpc.__version__) < Version("1.83.0rc0"): + if Version(grpc.__version__) < Version("1.83.0"): # TODO(https://github.com/googleapis/google-cloud-python/issues/17751): # Update the version in the check above to `1.83.0` once released. pytest.skip(f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})") @@ -69,7 +69,7 @@ async def test_pqc_grpc_async(intercepted_echo_grpc_async): """Verifies that the async gRPC client library negotiates post-quantum MLKEM with Showcase server.""" # TODO(https://github.com/googleapis/google-cloud-python/issues/17752): # Remove this check once grpcio >= 1.83.0 is enforced across all client libraries. - if Version(grpc.__version__) < Version("1.83.0rc0"): + if Version(grpc.__version__) < Version("1.83.0"): # TODO(https://github.com/googleapis/google-cloud-python/issues/17751): # Update the version in the check above to `1.83.0` once released. pytest.skip( From 660160d0172bb98c761e0be60a38d3733f7c54b5 Mon Sep 17 00:00:00 2001 From: ohmayr Date: Thu, 23 Jul 2026 16:36:43 +0000 Subject: [PATCH 2/3] cleanup --- packages/gapic-generator/tests/system/test_pqc.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/gapic-generator/tests/system/test_pqc.py b/packages/gapic-generator/tests/system/test_pqc.py index 855fec0f341e..5d99b2b70225 100644 --- a/packages/gapic-generator/tests/system/test_pqc.py +++ b/packages/gapic-generator/tests/system/test_pqc.py @@ -46,8 +46,6 @@ def test_pqc_grpc(intercepted_echo_grpc): # TODO(https://github.com/googleapis/google-cloud-python/issues/17752): # Remove this check once grpcio >= 1.83.0 is enforced across all client libraries. if Version(grpc.__version__) < Version("1.83.0"): - # TODO(https://github.com/googleapis/google-cloud-python/issues/17751): - # Update the version in the check above to `1.83.0` once released. pytest.skip(f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})") client, interceptor = intercepted_echo_grpc @@ -70,8 +68,6 @@ async def test_pqc_grpc_async(intercepted_echo_grpc_async): # TODO(https://github.com/googleapis/google-cloud-python/issues/17752): # Remove this check once grpcio >= 1.83.0 is enforced across all client libraries. if Version(grpc.__version__) < Version("1.83.0"): - # TODO(https://github.com/googleapis/google-cloud-python/issues/17751): - # Update the version in the check above to `1.83.0` once released. pytest.skip( f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})" ) From 7e34516daf854e9e2d5f471c60477e169775d13c Mon Sep 17 00:00:00 2001 From: ohmayr Date: Thu, 23 Jul 2026 16:38:03 +0000 Subject: [PATCH 3/3] remove --pre flag --- packages/gapic-generator/noxfile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/gapic-generator/noxfile.py b/packages/gapic-generator/noxfile.py index 1180b3fd294e..621a37b9278c 100644 --- a/packages/gapic-generator/noxfile.py +++ b/packages/gapic-generator/noxfile.py @@ -498,7 +498,7 @@ def showcase_pqc( """Run the Showcase PQC verification test suite against grpcio 1.83+ over standard TLS.""" with showcase_library(session, templates=templates, other_opts=other_opts): session.install("pytest", "pytest-asyncio") - session.install("--pre", "--upgrade", "grpcio>=1.83.0", "grpcio-status>=1.83.0") + session.install("--upgrade", "grpcio>=1.83.0", "grpcio-status>=1.83.0") session.run("py.test", "--quiet", "--tls", *(session.posargs or ["tests/system/test_pqc.py"]), env=env)