Skip to content

chore(generator): update pqc system tests to use grpcio 1.83.0 #17881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 3 commits into from
Jul 23, 2026
+3 −9
Merged

chore(generator): update pqc system tests to use grpcio 1.83.0 #17881

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0cdfcb
chore(generator): update pqc system tests to use grpcio 1.83.0
ohmayr Jul 23, 2026
660160d
cleanup
ohmayr Jul 23, 2026
7e34516
remove --pre flag
ohmayr Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/gapic-generator/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,9 +498,7 @@ def showcase_pqc(
"""Run the Showcase PQC verification test suite against grpcio 1.83+ over standard TLS."""
with showcase_library(session, templates=templates, other_opts=other_opts):
session.install("pytest", "pytest-asyncio")
# TODO(https://github.com/googleapis/google-cloud-python/issues/17751):
# Update the version below to `1.83.0` once released, and remove `--pre`.
session.install("--pre", "--upgrade", "grpcio>=1.83.0rc0", "grpcio-status>=1.83.0rc0")
session.install("--pre", "--upgrade", "grpcio>=1.83.0", "grpcio-status>=1.83.0")
Comment thread
ohmayr marked this conversation as resolved.
Outdated
session.run("py.test", "--quiet", "--tls", *(session.posargs or ["tests/system/test_pqc.py"]), env=env)


Expand Down
4 changes: 2 additions & 2 deletions packages/gapic-generator/tests/system/test_pqc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_pqc_grpc(intercepted_echo_grpc):
"""Verifies that the gRPC client library negotiates post-quantum MLKEM with Showcase server."""
# TODO(https://github.com/googleapis/google-cloud-python/issues/17752):
# Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
if Version(grpc.__version__) < Version("1.83.0rc0"):
if Version(grpc.__version__) < Version("1.83.0"):
Comment thread
ohmayr marked this conversation as resolved.
# TODO(https://github.com/googleapis/google-cloud-python/issues/17751):
# Update the version in the check above to `1.83.0` once released.
pytest.skip(f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})")
Expand All @@ -69,7 +69,7 @@ async def test_pqc_grpc_async(intercepted_echo_grpc_async):
"""Verifies that the async gRPC client library negotiates post-quantum MLKEM with Showcase server."""
# TODO(https://github.com/googleapis/google-cloud-python/issues/17752):
# Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
if Version(grpc.__version__) < Version("1.83.0rc0"):
if Version(grpc.__version__) < Version("1.83.0"):
Comment thread
ohmayr marked this conversation as resolved.
# TODO(https://github.com/googleapis/google-cloud-python/issues/17751):
# Update the version in the check above to `1.83.0` once released.
pytest.skip(
Expand Down
Loading