chore(preview): onboard compute preview client - #17918
Draft
noahdietz wants to merge 3 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new preview package for google-cloud-compute (version 1.51.0-preview.1) under the preview-packages directory, including its full client library code, REST transports, pagers, and Sphinx documentation. It also updates ci/run_conditional_tests.sh to include the new directory in conditional tests and configures the preview package in librarian.yaml. There are no review comments to address, so I have no further feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboards generation of the Compute v1 API found in the
googleapissubdirectory//preview(link). This is currently a mirror of the "stable" API found under the root.The same API updates for
//google/cloud/compute/v1are applied to//preview/google/cloud/compute/v1and we will see updates to this client in futurelibrariansources.googleapisupdates.This library is not onboarded to release-please and will not be released until a later date - the
librarian.yamlversion will lag for some time. This onboarding is done ahead of time to set the stage and work out kinks prior to release.The unit test and kokoro-based CI scripts are updated to include the
preview-packagessubdirectory.There are no system tests yet, but they may be added in a future PR, during which I'd update the system test script to inspect
preview-packagesas well aspackages.Fixes googleapis/librarian#5896