Skip to content

Commit 348de47

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
feat: update gapic-common dependency to 1.3 and document retry jitter (#34038)
* feat: update gapic-common dependency to 1.3 and document retry jitter docs: list Ruby 3.2+ as supported versions in README fix: rename client variable in tests PiperOrigin-RevId: 930120621 Source-Link: googleapis/googleapis@f7b1717 Source-Link: googleapis/googleapis-gen@e38df62 Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFjY2Vzc19hcHByb3ZhbC8uT3dsQm90LnlhbWwiLCJoIjoiZTM4ZGY2Mjg1ZDkxOThmZTY5MWU2ZDhiNTNlNzZmYjUxY2RkZjVjYyJ9 Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFkdmlzb3J5X25vdGlmaWNhdGlvbnMtdjEvLk93bEJvdC55YW1sIiwiaCI6ImUzOGRmNjI4NWQ5MTk4ZmU2OTFlNmQ4YjUzZTc2ZmI1MWNkZGY1Y2MifQ== Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFkdmlzb3J5X25vdGlmaWNhdGlvbnMvLk93bEJvdC55YW1sIiwiaCI6ImUzOGRmNjI4NWQ5MTk4ZmU2OTFlNmQ4YjUzZTc2ZmI1MWNkZGY1Y2MifQ== Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFpX3BsYXRmb3JtLXYxLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFpX3BsYXRmb3JtLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFsbG95X2RiLXYxLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFsbG95X2RiLXYxYWxwaGEvLk93bEJvdC55YW1sIiwiaCI6ImUzOGRmNjI4NWQ5MTk4ZmU2OTFlNmQ4YjUzZTc2ZmI1MWNkZGY1Y2MifQ== Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFsbG95X2RiLXYxYmV0YS8uT3dsQm90LnlhbWwiLCJoIjoiZTM4ZGY2Mjg1ZDkxOThmZTY5MWU2ZDhiNTNlNzZmYjUxY2RkZjVjYyJ9 Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFsbG95X2RiLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9nYXRld2F5LXYxLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9nYXRld2F5Ly5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9odWItdjEvLk93bEJvdC55YW1sIiwiaCI6ImUzOGRmNjI4NWQ5MTk4ZmU2OTFlNmQ4YjUzZTc2ZmI1MWNkZGY1Y2MifQ== Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9odWIvLk93bEJvdC55YW1sIiwiaCI6ImUzOGRmNjI4NWQ5MTk4ZmU2OTFlNmQ4YjUzZTc2ZmI1MWNkZGY1Y2MifQ== Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9rZXlzLXYyLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9rZXlzLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9yZWdpc3RyeS12MWJldGEvLk93bEJvdC55YW1sIiwiaCI6ImUzOGRmNjI4NWQ5MTk4ZmU2OTFlNmQ4YjUzZTc2ZmI1MWNkZGY1Y2MifQ== Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaV9yZWdpc3RyeS8uT3dsQm90LnlhbWwiLCJoIjoiZTM4ZGY2Mjg1ZDkxOThmZTY5MWU2ZDhiNTNlNzZmYjUxY2RkZjVjYyJ9 Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaWdlZV9jb25uZWN0LXYxLy5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaWdlZV9jb25uZWN0Ly5Pd2xCb3QueWFtbCIsImgiOiJlMzhkZjYyODVkOTE5OGZlNjkxZTZkOGI1M2U3NmZiNTFjZGRmNWNjIn0= Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLWFwaWdlZV9yZWdpc3RyeS12MS8uT3dsQm90LnlhbWwiLCJoIjoiZTM4ZGY2Mjg1ZDkxOThmZTY5MWU2ZDhiNTNlNzZmYjUxY2RkZjVjYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 453b4c5 commit 348de47

371 files changed

Lines changed: 8362 additions & 7947 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎google-cloud-access_approval/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ working, try updating the versioned clients in your bundle or installed gems:
7474

7575
## Supported Ruby Versions
7676

77-
This library is supported on Ruby 3.0+.
77+
This library is supported on Ruby 3.2+.
7878

7979
Google provides official support for Ruby versions that are actively supported
8080
by Ruby Core—that is, Ruby versions that are either in normal maintenance or

‎google-cloud-access_approval/lib/google/cloud/access_approval.rb‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ def self.access_approval_available? version: :v1, transport: :grpc
170170
# * `:initial_delay` (*type:* `Numeric`) - The initial delay in seconds.
171171
# * `:max_delay` (*type:* `Numeric`) - The max delay in seconds.
172172
# * `:multiplier` (*type:* `Numeric`) - The incremental backoff multiplier.
173+
# * `:jitter` (*type:* `Numeric`) - The jitter in seconds. Default: 1.0.
173174
# * `:retry_codes` (*type:* `Array<String>`) -
174175
# The error codes that should trigger a retry.
175176
#

‎google-cloud-advisory_notifications-v1/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ To browse ready to use code samples check [Google Cloud Samples](https://cloud.g
8585

8686
## Supported Ruby Versions
8787

88-
This library is supported on Ruby 3.0+.
88+
This library is supported on Ruby 3.2+.
8989

9090
Google provides official support for Ruby versions that are actively supported
9191
by Ruby Core—that is, Ruby versions that are either in normal maintenance or

‎google-cloud-advisory_notifications-v1/google-cloud-advisory_notifications-v1.gemspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ Gem::Specification.new do |gem|
2323

2424
gem.required_ruby_version = ">= 3.2"
2525

26-
gem.add_dependency "gapic-common", "~> 1.2"
26+
gem.add_dependency "gapic-common", "~> 1.3"
2727
gem.add_dependency "google-cloud-errors", "~> 1.0"
2828
end

‎google-cloud-advisory_notifications-v1/lib/google/cloud/advisory_notifications/v1/advisory_notifications_service/client.rb‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -667,6 +667,7 @@ def update_settings request, options = nil
667667
# * `:initial_delay` (*type:* `Numeric`) - The initial delay in seconds.
668668
# * `:max_delay` (*type:* `Numeric`) - The max delay in seconds.
669669
# * `:multiplier` (*type:* `Numeric`) - The incremental backoff multiplier.
670+
# * `:jitter` (*type:* `Numeric`) - The jitter in seconds. Default: 1.0.
670671
# * `:retry_codes` (*type:* `Array<String>`) - The error codes that should
671672
# trigger a retry.
672673
# @return [::Hash]
@@ -750,6 +751,7 @@ def channel_pool
750751
# * `:initial_delay` (*type:* `Numeric`) - The initial delay in seconds.
751752
# * `:max_delay` (*type:* `Numeric`) - The max delay in seconds.
752753
# * `:multiplier` (*type:* `Numeric`) - The incremental backoff multiplier.
754+
# * `:jitter` (*type:* `Numeric`) - The jitter in seconds. Default: 1.0.
753755
# * `:retry_codes` (*type:* `Array<String>`) - The error codes that should
754756
# trigger a retry.
755757
#

‎google-cloud-advisory_notifications-v1/lib/google/cloud/advisory_notifications/v1/advisory_notifications_service/rest/client.rb‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,7 @@ def update_settings request, options = nil
606606
# * `:initial_delay` (*type:* `Numeric`) - The initial delay in seconds.
607607
# * `:max_delay` (*type:* `Numeric`) - The max delay in seconds.
608608
# * `:multiplier` (*type:* `Numeric`) - The incremental backoff multiplier.
609+
# * `:jitter` (*type:* `Numeric`) - The jitter in seconds. Default: 1.0.
609610
# * `:retry_codes` (*type:* `Array<String>`) - The error codes that should
610611
# trigger a retry.
611612
# @return [::Hash]
@@ -678,6 +679,7 @@ def rpcs
678679
# * `:initial_delay` (*type:* `Numeric`) - The initial delay in seconds.
679680
# * `:max_delay` (*type:* `Numeric`) - The max delay in seconds.
680681
# * `:multiplier` (*type:* `Numeric`) - The incremental backoff multiplier.
682+
# * `:jitter` (*type:* `Numeric`) - The jitter in seconds. Default: 1.0.
681683
# * `:retry_codes` (*type:* `Array<String>`) - The error codes that should
682684
# trigger a retry.
683685
#

‎google-cloud-advisory_notifications-v1/proto_docs/google/api/client.rb‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ module Api
3131
# @!attribute [rw] selective_gapic_generation
3232
# @return [::Google::Api::SelectiveGapicGeneration]
3333
# Configuration for which RPCs should be generated in the GAPIC client.
34+
#
35+
# Note: This field should not be used in most cases.
3436
class CommonLanguageSettings
3537
include ::Google::Protobuf::MessageExts
3638
extend ::Google::Protobuf::MessageExts::ClassMethods
@@ -441,6 +443,8 @@ class LongRunning
441443

442444
# This message is used to configure the generation of a subset of the RPCs in
443445
# a service for client libraries.
446+
#
447+
# Note: This feature should not be used in most cases.
444448
# @!attribute [rw] methods
445449
# @return [::Array<::String>]
446450
# An allowlist of the fully qualified names of RPCs that should be included

‎google-cloud-advisory_notifications-v1/test/google/cloud/advisory_notifications/v1/advisory_notifications_service_rest_test.rb‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -101,32 +101,32 @@ def test_list_notifications
101101
::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::ServiceStub.stub :transcode_list_notifications_request, ["", "", {}] do
102102
Gapic::Rest::ClientStub.stub :new, list_notifications_client_stub do
103103
# Create client
104-
client = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
104+
c = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
105105
config.credentials = :dummy_value
106106
end
107107

108108
# Use hash object
109-
client.list_notifications({ parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code }) do |_result, response|
109+
c.list_notifications({ parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code }) do |_result, response|
110110
assert_equal http_response, response.underlying_op
111111
end
112112

113113
# Use named arguments
114-
client.list_notifications parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code do |_result, response|
114+
c.list_notifications parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code do |_result, response|
115115
assert_equal http_response, response.underlying_op
116116
end
117117

118118
# Use protobuf object
119-
client.list_notifications ::Google::Cloud::AdvisoryNotifications::V1::ListNotificationsRequest.new(parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code) do |_result, response|
119+
c.list_notifications ::Google::Cloud::AdvisoryNotifications::V1::ListNotificationsRequest.new(parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code) do |_result, response|
120120
assert_equal http_response, response.underlying_op
121121
end
122122

123123
# Use hash object with options
124-
client.list_notifications({ parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code }, call_options) do |_result, response|
124+
c.list_notifications({ parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code }, call_options) do |_result, response|
125125
assert_equal http_response, response.underlying_op
126126
end
127127

128128
# Use protobuf object with options
129-
client.list_notifications(::Google::Cloud::AdvisoryNotifications::V1::ListNotificationsRequest.new(parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code), call_options) do |_result, response|
129+
c.list_notifications(::Google::Cloud::AdvisoryNotifications::V1::ListNotificationsRequest.new(parent: parent, page_size: page_size, page_token: page_token, view: view, language_code: language_code), call_options) do |_result, response|
130130
assert_equal http_response, response.underlying_op
131131
end
132132

@@ -156,32 +156,32 @@ def test_get_notification
156156
::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::ServiceStub.stub :transcode_get_notification_request, ["", "", {}] do
157157
Gapic::Rest::ClientStub.stub :new, get_notification_client_stub do
158158
# Create client
159-
client = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
159+
c = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
160160
config.credentials = :dummy_value
161161
end
162162

163163
# Use hash object
164-
client.get_notification({ name: name, language_code: language_code }) do |_result, response|
164+
c.get_notification({ name: name, language_code: language_code }) do |_result, response|
165165
assert_equal http_response, response.underlying_op
166166
end
167167

168168
# Use named arguments
169-
client.get_notification name: name, language_code: language_code do |_result, response|
169+
c.get_notification name: name, language_code: language_code do |_result, response|
170170
assert_equal http_response, response.underlying_op
171171
end
172172

173173
# Use protobuf object
174-
client.get_notification ::Google::Cloud::AdvisoryNotifications::V1::GetNotificationRequest.new(name: name, language_code: language_code) do |_result, response|
174+
c.get_notification ::Google::Cloud::AdvisoryNotifications::V1::GetNotificationRequest.new(name: name, language_code: language_code) do |_result, response|
175175
assert_equal http_response, response.underlying_op
176176
end
177177

178178
# Use hash object with options
179-
client.get_notification({ name: name, language_code: language_code }, call_options) do |_result, response|
179+
c.get_notification({ name: name, language_code: language_code }, call_options) do |_result, response|
180180
assert_equal http_response, response.underlying_op
181181
end
182182

183183
# Use protobuf object with options
184-
client.get_notification(::Google::Cloud::AdvisoryNotifications::V1::GetNotificationRequest.new(name: name, language_code: language_code), call_options) do |_result, response|
184+
c.get_notification(::Google::Cloud::AdvisoryNotifications::V1::GetNotificationRequest.new(name: name, language_code: language_code), call_options) do |_result, response|
185185
assert_equal http_response, response.underlying_op
186186
end
187187

@@ -210,32 +210,32 @@ def test_get_settings
210210
::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::ServiceStub.stub :transcode_get_settings_request, ["", "", {}] do
211211
Gapic::Rest::ClientStub.stub :new, get_settings_client_stub do
212212
# Create client
213-
client = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
213+
c = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
214214
config.credentials = :dummy_value
215215
end
216216

217217
# Use hash object
218-
client.get_settings({ name: name }) do |_result, response|
218+
c.get_settings({ name: name }) do |_result, response|
219219
assert_equal http_response, response.underlying_op
220220
end
221221

222222
# Use named arguments
223-
client.get_settings name: name do |_result, response|
223+
c.get_settings name: name do |_result, response|
224224
assert_equal http_response, response.underlying_op
225225
end
226226

227227
# Use protobuf object
228-
client.get_settings ::Google::Cloud::AdvisoryNotifications::V1::GetSettingsRequest.new(name: name) do |_result, response|
228+
c.get_settings ::Google::Cloud::AdvisoryNotifications::V1::GetSettingsRequest.new(name: name) do |_result, response|
229229
assert_equal http_response, response.underlying_op
230230
end
231231

232232
# Use hash object with options
233-
client.get_settings({ name: name }, call_options) do |_result, response|
233+
c.get_settings({ name: name }, call_options) do |_result, response|
234234
assert_equal http_response, response.underlying_op
235235
end
236236

237237
# Use protobuf object with options
238-
client.get_settings(::Google::Cloud::AdvisoryNotifications::V1::GetSettingsRequest.new(name: name), call_options) do |_result, response|
238+
c.get_settings(::Google::Cloud::AdvisoryNotifications::V1::GetSettingsRequest.new(name: name), call_options) do |_result, response|
239239
assert_equal http_response, response.underlying_op
240240
end
241241

@@ -264,32 +264,32 @@ def test_update_settings
264264
::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::ServiceStub.stub :transcode_update_settings_request, ["", "", {}] do
265265
Gapic::Rest::ClientStub.stub :new, update_settings_client_stub do
266266
# Create client
267-
client = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
267+
c = ::Google::Cloud::AdvisoryNotifications::V1::AdvisoryNotificationsService::Rest::Client.new do |config|
268268
config.credentials = :dummy_value
269269
end
270270

271271
# Use hash object
272-
client.update_settings({ settings: settings }) do |_result, response|
272+
c.update_settings({ settings: settings }) do |_result, response|
273273
assert_equal http_response, response.underlying_op
274274
end
275275

276276
# Use named arguments
277-
client.update_settings settings: settings do |_result, response|
277+
c.update_settings settings: settings do |_result, response|
278278
assert_equal http_response, response.underlying_op
279279
end
280280

281281
# Use protobuf object
282-
client.update_settings ::Google::Cloud::AdvisoryNotifications::V1::UpdateSettingsRequest.new(settings: settings) do |_result, response|
282+
c.update_settings ::Google::Cloud::AdvisoryNotifications::V1::UpdateSettingsRequest.new(settings: settings) do |_result, response|
283283
assert_equal http_response, response.underlying_op
284284
end
285285

286286
# Use hash object with options
287-
client.update_settings({ settings: settings }, call_options) do |_result, response|
287+
c.update_settings({ settings: settings }, call_options) do |_result, response|
288288
assert_equal http_response, response.underlying_op
289289
end
290290

291291
# Use protobuf object with options
292-
client.update_settings(::Google::Cloud::AdvisoryNotifications::V1::UpdateSettingsRequest.new(settings: settings), call_options) do |_result, response|
292+
c.update_settings(::Google::Cloud::AdvisoryNotifications::V1::UpdateSettingsRequest.new(settings: settings), call_options) do |_result, response|
293293
assert_equal http_response, response.underlying_op
294294
end
295295

0 commit comments

Comments
 (0)