feat(o11y): utilize opentelemetry-appender-tracing otel_target for dynamic artifact logging

Author: haphungw

Cargo.lock

@@ -534,3 +534,10 @@ unexpected_cfgs = { level = "deny", check-cfg = [
   'cfg(google_cloud_generate_protos)',
   'cfg(tokio_unstable)',
 ] }
+
+[patch.crates-io]
+opentelemetry-appender-tracing = { path = "../opentelemetry-rust/opentelemetry-appender-tracing" }
+opentelemetry = { path = "../opentelemetry-rust/opentelemetry" }
+opentelemetry_sdk = { path = "../opentelemetry-rust/opentelemetry-sdk" }
+opentelemetry-semantic-conventions = { path = "../opentelemetry-rust/opentelemetry-semantic-conventions" }
+opentelemetry-otlp = { path = "../opentelemetry-rust/opentelemetry-otlp" }

Cargo.toml

@@ -112,7 +112,7 @@ macro_rules! client_request_signals {
 #[cfg(test)]
 mod tests {
     use super::duration_metric::BOUNDARIES;
-    use super::with_client_logging::{NAME, TARGET};
+    use super::with_client_logging::NAME;
     use super::{ClientRequestAttributes, RequestRecorder};
     use crate::observability::DurationMetric;
     use crate::options::InstrumentationClientInfo;
@@ -288,11 +288,12 @@ mod tests {
         let captured = signals.logs_exporter.get_emitted_logs()?;
         let record = captured
             .iter()
-            .find(|r| r.record.target().is_some_and(|v| v == TARGET))
-            .unwrap_or_else(|| panic!("missing log for target {TARGET} in {captured:#?}"));
+            .find(|r| r.record.target().is_some_and(|v| v == "test-artifact"))
+            .unwrap_or_else(|| panic!("missing log for target test-artifact in {captured:#?}"));
         check_log_record(
             &record.record,
             trace_id,
+            "test-artifact",
             &[
                 ("gcp.client.version", "1.2.3"),
                 ("gcp.client.repo", "googleapis/google-cloud-rust"),
@@ -459,6 +460,7 @@ mod tests {
     pub fn check_log_record(
         record: &SdkLogRecord,
         trace_id: TraceId,
+        expected_target: &str,
         extra_attributes: &[(&'static str, &str)],
     ) {
         fn format_value(any: &AnyValue) -> String {
@@ -473,7 +475,7 @@ mod tests {
         assert_eq!(record.event_name(), Some(NAME), "{record:?}");
         assert_eq!(
             record.target().map(|s| s.as_ref()),
-            Some(TARGET),
+            Some(expected_target),
             "{record:?}"
         );
         assert_eq!(record.severity_text(), Some("WARN"), "{record:?}");

src/gax-internal/src/observability/client_signals.rs

@@ -33,8 +33,6 @@ use std::task::{Context, Poll};
 
 // A tentative name for the error logs.
 pub const NAME: &str = "experimental.client.request.error";
-// A tentative target for the error logs.
-pub const TARGET: &str = "experimental.client.request";
 
 /// A future instrumented to generate the client request logs.
 ///
@@ -104,11 +102,11 @@ where
                     }
                 });
 
-                // TODO(#4795) - use the correct name and target
                 tracing::event!(
                     name: NAME,
-                    target: TARGET,
+                    target: NAME, // Default fallback target
                     tracing::Level::WARN,
+                    otel_target = snapshot.client_artifact(),
                     { RPC_SYSTEM_NAME } = snapshot.rpc_system(),
                     { RPC_SERVICE } = snapshot.service_name(),
                     { RPC_METHOD } = snapshot.rpc_method(),
@@ -206,13 +204,14 @@ mod tests {
         assert!(object.remove("timestamp").is_some(), "{parsed:?}");
         let want = json!({
             "level": "WARN",
-            "target": "experimental.client.request",
+            "target": NAME,
         });
         assert_eq!(Some(&object), want.as_object(), "{parsed:?}");
 
         // Don't care about the formatted message, this is not a test for Error formatting.
         assert!(fields.remove("message").is_some(), "{parsed:?}");
         let want = json!({
+            "otel_target": "test-artifact",
             "error.type": "CLIENT_CONNECTION_ERROR",
             "rpc.system.name": "http",
             "rpc.method": TEST_METHOD,
@@ -268,13 +267,14 @@ mod tests {
         assert!(object.remove("timestamp").is_some(), "{parsed:?}");
         let want = json!({
             "level": "WARN",
-            "target": "experimental.client.request",
+            "target": NAME,
         });
         assert_eq!(Some(&object), want.as_object(), "{parsed:?}");
 
         // Don't care about the formatted message, this is not a test for Error formatting.
         assert!(fields.remove("message").is_some(), "{parsed:?}");
         let want = json!({
+            "otel_target": "test-artifact",
             "rpc.system.name": "http",
             "rpc.method": TEST_METHOD,
             "rpc.service": "test-service",