Skip to content

impl(cloud-run-o11y): observability demo#5214

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:impl-v7-cloud-run-demo
Apr 6, 2026
Merged

impl(cloud-run-o11y): observability demo#5214
coryan merged 1 commit intogoogleapis:mainfrom
coryan:impl-v7-cloud-run-demo

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Mar 31, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (8cc7ac3) to head (d850f45).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5214      +/-   ##
==========================================
- Coverage   97.98%   97.98%   -0.01%     
==========================================
  Files         215      215              
  Lines       44904    44904              
==========================================
- Hits        44000    43998       -2     
- Misses        904      906       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan force-pushed the impl-v7-cloud-run-demo branch 3 times, most recently from 3bb7994 to 54889a1 Compare April 2, 2026 13:01
@coryan coryan marked this pull request as ready for review April 2, 2026 16:18
@coryan coryan requested a review from a team as a code owner April 2, 2026 16:18
@coryan coryan force-pushed the impl-v7-cloud-run-demo branch from 54889a1 to d850f45 Compare April 3, 2026 19:30
@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented Apr 6, 2026

Ping

@haphungw
Copy link
Copy Markdown
Contributor

haphungw commented Apr 6, 2026

Quick question about the audience for this demo. Is this for us to see how to wire up o11y, or are we planning this as a public sample for external users?

The implementation relies on integration_tests_o11y which is not accessible for external users, so technically they can't copy paste this demo code right?

@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented Apr 6, 2026

Quick question about the audience for this demo. Is this for us to see how to wire up o11y, or are we planning this as a public sample for external users?

It is for us, and it show us how difficult / easy it is to wire up o11y. We can also use it to generate cool screenshots.

The implementation relies on integration_tests_o11y which is not accessible for external users, so technically they can't copy paste this demo code right?

They can't... but they could cut&paste that code too. nudge nudge, wink wink. Though #5223 may be a better approach for that the things in integration-tests-o11y do.

@coryan coryan merged commit e96c4c8 into googleapis:main Apr 6, 2026
36 checks passed
@coryan coryan deleted the impl-v7-cloud-run-demo branch April 6, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants