feat: regenerate libraries using protobuf 33.2, and update generation script#5552
Draft
feat: regenerate libraries using protobuf 33.2, and update generation script#5552
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5552 +/- ##
=======================================
Coverage 97.75% 97.76%
=======================================
Files 218 218
Lines 49555 49555
=======================================
+ Hits 48444 48445 +1
+ Misses 1111 1110 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
FWIW, I had to re-add I can't tell if the protoc upgrade is (accurately?) removing this, or if I'm using the wrong generation process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reran generation using protoc 33.2
This regeneration introduces a minor, non-breaking change to the
from_stubfunction signature in generated client files across many services. The signature has been updated from:pub fn from_stub<T>(stub: T) -> Selfto:
pub fn from_stub<T>(stub: impl Into<std::sync::Arc<T>>) -> SelfThis provides more flexibility when creating clients from custom or mocked stubs in tests. Any type that can be converted into an
Arccan now be passed directly, rather than requiring the caller to wrap it in anArcmanually.The rest of the changes are metadata and comment cleanups (such as the removal of redundant
/// Creates a new default instance.comments).Fixes: googleapis/librarian#5283