feat(o11y): add error extraction to DiscoveryOperation and fix macro compatibility#5843
Open
haphungw wants to merge 3 commits into
Open
feat(o11y): add error extraction to DiscoveryOperation and fix macro compatibility#5843haphungw wants to merge 3 commits into
haphungw wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an error method to the DiscoveryOperation trait and adds helper macros record_discovery_polling_result! and record_polling_attributes! to handle telemetry and span attribute recording for Discovery LROs. The reviewer pointed out a macro hazard in record_discovery_polling_result! where arguments are evaluated multiple times, and suggested binding them to local references first to prevent unexpected behavior or performance issues.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5843 +/- ##
==========================================
- Coverage 97.89% 97.88% -0.01%
==========================================
Files 226 226
Lines 57713 57716 +3
==========================================
Hits 56496 56496
- Misses 1217 1220 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
fix-discovery-lro-error
branch
from
b50f550 to
9b46cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce telemetry injections for Discovery LROs.
This ensures Discovery LROs can record rich error details upon completion, matching the behavior of standard LROs, and provides a cleaner interface for code generation.
Used at googleapis/librarian#6304.