chore: more pacemaker into tracers (#2822)

* chore: more pacemaker into tracers

Change-Id: I509051afa46164524fd3292564eee2d61a91c06a

* oops, upate pacemaker visibility

Change-Id: I326e1a485c559f3e9d108d373deac5ea73913f62

Author: igorbernstein2

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/MetricRegistry.java

@@ -192,7 +192,7 @@ public class RecorderRegistry {
 
     public final TableDebugTagCount.Recorder debugTagCount;
 
-    final PacemakerDelay.Recorder pacemakerDelay;
+    public final PacemakerDelay.Recorder pacemakerDelay;
 
     private RecorderRegistry(Meter meter) {
       operationLatency = operationLatencyMetric.newRecorder(meter);

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/MetricsImpl.java

@@ -31,6 +31,7 @@
 import com.google.cloud.bigtable.data.v2.internal.csm.tracers.BuiltinMetricsTracerFactory;
 import com.google.cloud.bigtable.data.v2.internal.csm.tracers.ChannelPoolMetricsTracer;
 import com.google.cloud.bigtable.data.v2.internal.csm.tracers.CompositeTracerFactory;
+import com.google.cloud.bigtable.data.v2.internal.csm.tracers.Pacemaker;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
@@ -50,7 +51,6 @@
 import java.util.List;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.ScheduledFuture;
-import java.util.concurrent.TimeUnit;
 import javax.annotation.Nullable;
 
 public class MetricsImpl implements Metrics, Closeable {
@@ -134,12 +134,7 @@ public void start() {
       tasks.add(channelPoolMetricsTracer.start(executor));
     }
     if (pacemaker != null) {
-      tasks.add(
-          executor.scheduleAtFixedRate(
-              pacemaker,
-              Pacemaker.PACEMAKER_INTERVAL.toMillis(),
-              Pacemaker.PACEMAKER_INTERVAL.toMillis(),
-              TimeUnit.MILLISECONDS));
+      tasks.add(pacemaker.start(executor));
     }
   }
 

…able/data/v2/internal/csm/Pacemaker.java …a/v2/internal/csm/tracers/Pacemaker.javagoogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/Pacemaker.java renamed to google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/Pacemaker.java google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/Pacemaker.java renamed to google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/Pacemaker.java

@@ -13,14 +13,17 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package com.google.cloud.bigtable.data.v2.internal.csm;
+package com.google.cloud.bigtable.data.v2.internal.csm.tracers;
 
 import com.google.cloud.bigtable.data.v2.internal.csm.MetricRegistry.RecorderRegistry;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
 import java.time.Duration;
 import java.time.Instant;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
 
-class Pacemaker implements Runnable {
+public class Pacemaker implements Runnable {
 
   static final Duration PACEMAKER_INTERVAL = Duration.ofMillis(100);
 
@@ -30,13 +33,21 @@ class Pacemaker implements Runnable {
 
   private Instant prev;
 
-  Pacemaker(RecorderRegistry registry, ClientInfo clientInfo, String name) {
+  public Pacemaker(RecorderRegistry registry, ClientInfo clientInfo, String name) {
     this.prev = Instant.now();
     this.registry = registry;
     this.clientInfo = clientInfo;
     this.executorName = name;
   }
 
+  public ScheduledFuture<?> start(ScheduledExecutorService executor) {
+    return executor.scheduleAtFixedRate(
+        this,
+        Pacemaker.PACEMAKER_INTERVAL.toMillis(),
+        Pacemaker.PACEMAKER_INTERVAL.toMillis(),
+        TimeUnit.MILLISECONDS);
+  }
+
   @Override
   public void run() {
     Instant current = Instant.now();