dont log failures when closed

igorbernstein2 · igorbernstein2 · commit 11d9e386638d · 2026-02-26T14:59:24.000-05:00
Change-Id: Id5f40c3919b1f94fc28ec6d38f929709aefa8687
diff --git a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java
@@ -191,7 +191,7 @@ public void onFailure(Throwable throwable) {
               RuntimeException asyncWrapper = new RuntimeException("export failed", throwable);
               asyncWrapper.setStackTrace(stackTrace);
 
-              if (state.get() != State.Closing) {
+              if (state.get() != State.Closing || state.get() != State.Closed) {
                 // ignore the export warning when client is shutting down
                 LOGGER.log(Level.WARNING, msg, asyncWrapper);
               }

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ public void onFailure(Throwable throwable) {`
`191`	`191`	`RuntimeException asyncWrapper = new RuntimeException("export failed", throwable);`
`192`	`192`	`asyncWrapper.setStackTrace(stackTrace);`
`193`	`193`
`194`		`- if (state.get() != State.Closing) {`
	`194`	`+ if (state.get() != State.Closing \|\| state.get() != State.Closed) {`
`195`	`195`	`// ignore the export warning when client is shutting down`
`196`	`196`	`LOGGER.log(Level.WARNING, msg, asyncWrapper);`
`197`	`197`	`}`