Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 175760c

Browse files
format
Change-Id: I9c8a10c98cef7fcea8b523e1a3cc4a93567677a7
1 parent 6be4510 commit 175760c

3 files changed

Lines changed: 10 additions & 24 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,13 @@
3939
import com.google.api.gax.core.NoCredentialsProvider;
4040
import com.google.api.gax.rpc.PermissionDeniedException;
4141
import com.google.auth.Credentials;
42+
import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
4243
import com.google.cloud.monitoring.v3.MetricServiceClient;
4344
import com.google.cloud.monitoring.v3.MetricServiceSettings;
4445
import com.google.common.annotations.VisibleForTesting;
4546
import com.google.common.base.Preconditions;
4647
import com.google.common.base.Supplier;
48+
import com.google.common.base.Suppliers;
4749
import com.google.common.collect.ImmutableList;
4850
import com.google.common.collect.ImmutableMap;
4951
import com.google.common.collect.ImmutableSet;
@@ -152,12 +154,12 @@ static BigtableCloudMonitoringExporter create(
152154
// it as not retried for now.
153155
settingsBuilder.createServiceTimeSeriesSettings().setSimpleTimeoutNoRetriesDuration(timeout);
154156

155-
ImmutableList<TimeSeriesConverter> converters = ImmutableList.of(
156-
new PublicTimeSeriesConverter(),
157-
new InternalTimeSeriesConverter(
158-
Suppliers.memoize(
159-
() ->
160-
BigtableExporterUtils.createInternalMonitoredResource(clientInfo))));
157+
ImmutableList<TimeSeriesConverter> converters =
158+
ImmutableList.of(
159+
new PublicTimeSeriesConverter(),
160+
new InternalTimeSeriesConverter(
161+
Suppliers.memoize(
162+
() -> BigtableExporterUtils.createInternalMonitoredResource(clientInfo))));
161163

162164
return new BigtableCloudMonitoringExporter(
163165
MetricServiceClient.create(settingsBuilder.build()), converters);

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import com.google.api.Distribution;
3939
import com.google.api.Metric;
4040
import com.google.api.MonitoredResource;
41-
import com.google.bigtable.v2.InstanceName;
4241
import com.google.cloud.bigtable.Version;
4342
import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
4443
import com.google.cloud.opentelemetry.detection.AttributeKeys;

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import com.google.bigtable.v2.AuthorizedViewName;
2828
import com.google.bigtable.v2.CheckAndMutateRowRequest;
2929
import com.google.bigtable.v2.GenerateInitialChangeStreamPartitionsRequest;
30-
import com.google.bigtable.v2.InstanceName;
3130
import com.google.bigtable.v2.MaterializedViewName;
3231
import com.google.bigtable.v2.MutateRowRequest;
3332
import com.google.bigtable.v2.MutateRowsRequest;
@@ -42,8 +41,6 @@
4241
import com.google.cloud.bigtable.data.v2.BigtableDataSettings;
4342
import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
4443
import com.google.cloud.bigtable.data.v2.stub.MetadataExtractorInterceptor;
45-
import com.google.common.base.Suppliers;
46-
import com.google.common.collect.ImmutableList;
4744
import com.google.common.collect.ImmutableMap;
4845
import io.grpc.Metadata;
4946
import io.grpc.Status;
@@ -162,8 +159,7 @@ static Map<String, List<String>> createStatsHeaders(ApiCallContext apiCallContex
162159
}
163160

164161
public static OpenTelemetrySdk createBuiltinOtel(
165-
InstanceName instanceName,
166-
String appProfileId,
162+
ClientInfo clientInfo,
167163
@Nullable Credentials defaultCredentials,
168164
@Nullable String metricsEndpoint,
169165
String universeDomain,
@@ -189,17 +185,7 @@ public static OpenTelemetrySdk createBuiltinOtel(
189185

190186
MetricExporter publicExporter =
191187
BigtableCloudMonitoringExporter.create(
192-
credentials,
193-
metricsEndpoint,
194-
universeDomain,
195-
ImmutableList.of(
196-
new BigtableCloudMonitoringExporter.PublicTimeSeriesConverter(),
197-
new BigtableCloudMonitoringExporter.InternalTimeSeriesConverter(
198-
Suppliers.memoize(
199-
() ->
200-
BigtableExporterUtils.createInternalMonitoredResource(
201-
instanceName, appProfileId)))),
202-
executor);
188+
clientInfo, credentials, metricsEndpoint, universeDomain, executor);
203189
PeriodicMetricReaderBuilder readerBuilder =
204190
PeriodicMetricReader.builder(publicExporter).setExecutor(executor);
205191
meterProvider.registerMetricReader(readerBuilder.build());
@@ -276,7 +262,6 @@ public static ApiTracerFactory createOCMetricsFactory(
276262
public static BuiltinMetricsTracerFactory createOtelMetricsFactory(
277263
OpenTelemetry otel, ClientInfo clientInfo) throws IOException {
278264

279-
280265
return BuiltinMetricsTracerFactory.create(otel, clientInfo);
281266
}
282267
}

0 commit comments

Comments
 (0)