Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 2ae875d

Browse files
committed
fixes
Change-Id: Ib414d250f9f1ce0555450e81a706f6c0619d80f2
1 parent 9a2b2dc commit 2ae875d

3 files changed

Lines changed: 14 additions & 23 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package com.google.cloud.bigtable.data.v2.stub;
1717

18-
import com.google.api.core.BetaApi;
18+
import com.google.api.core.InternalApi;
1919
import com.google.api.core.SettableApiFuture;
2020
import com.google.api.gax.grpc.ChannelPrimer;
2121
import com.google.auth.Credentials;
@@ -46,7 +46,7 @@
4646
* <p>This implementation is subject to change in the future, but currently it will prime the
4747
* channel by sending a ReadRow request for a hardcoded, non-existent row key.
4848
*/
49-
@BetaApi("Channel priming is not currently stable and might change in the future")
49+
@InternalApi("Channel priming is not currently stable and might change in the future")
5050
public class BigtableChannelPrimer implements ChannelPrimer {
5151
private static Logger LOG = Logger.getLogger(BigtableChannelPrimer.class.toString());
5252

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -121,26 +121,23 @@ public static BigtableClientContext create(EnhancedBigtableStubSettings settings
121121
setupCookieHolder(transportProvider);
122122
}
123123

124-
BigtableChannelPrimer channelPrimer =
125-
BigtableChannelPrimer.create(
126-
builder.getProjectId(),
127-
builder.getInstanceId(),
128-
builder.getAppProfileId(),
129-
credentials,
130-
builder.getHeaderProvider().getHeaders());
131-
132-
BigtableTransportChannelProvider btTransportProvider;
124+
BigtableChannelPrimer channelPrimer;
133125

134126
// Inject channel priming if enabled
135127
if (builder.isRefreshingChannel()) {
136-
btTransportProvider =
137-
BigtableTransportChannelProvider.create(
138-
(InstantiatingGrpcChannelProvider) transportProvider.build(), channelPrimer);
128+
channelPrimer =
129+
BigtableChannelPrimer.create(
130+
builder.getProjectId(),
131+
builder.getInstanceId(),
132+
builder.getAppProfileId(),
133+
credentials,
134+
builder.getHeaderProvider().getHeaders());
139135
} else {
140-
btTransportProvider =
141-
BigtableTransportChannelProvider.createWithoutChannelPriming(
142-
(InstantiatingGrpcChannelProvider) transportProvider.build());
136+
channelPrimer = null;
143137
}
138+
BigtableTransportChannelProvider btTransportProvider =
139+
BigtableTransportChannelProvider.create(
140+
(InstantiatingGrpcChannelProvider) transportProvider.build(), channelPrimer);
144141

145142
builder.setTransportChannelProvider(btTransportProvider);
146143
}

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,6 @@ public TransportChannelProvider withCredentials(Credentials credentials) {
162162
public static BigtableTransportChannelProvider create(
163163
InstantiatingGrpcChannelProvider instantiatingGrpcChannelProvider,
164164
BigtableChannelPrimer channelPrimer) {
165-
Preconditions.checkNotNull(channelPrimer);
166165
return new BigtableTransportChannelProvider(instantiatingGrpcChannelProvider, channelPrimer);
167166
}
168-
169-
public static BigtableTransportChannelProvider createWithoutChannelPriming(
170-
InstantiatingGrpcChannelProvider instantiatingGrpcChannelProvider) {
171-
return new BigtableTransportChannelProvider(instantiatingGrpcChannelProvider, null);
172-
}
173167
}

0 commit comments

Comments
 (0)