Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 34d1bd4

Browse files
committed
nits
Change-Id: I340c377678834ff07b1c4b43afbc89edfe645b39
1 parent 6e1321a commit 34d1bd4

3 files changed

Lines changed: 4 additions & 7 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
*
5252
* <p>Internal API
5353
*/
54-
@InternalApi("")
54+
@InternalApi
5555
public class BigtableChannelPool extends ManagedChannel {
5656
@VisibleForTesting
5757
static final Logger LOG = Logger.getLogger(BigtableChannelPool.class.getName());

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import java.util.concurrent.Executor;
3131
import java.util.concurrent.ScheduledExecutorService;
3232

33-
/** An instance of TransportChannelProvider that always provides the same TransportChannel. */
33+
/** An instance of TransportChannelProvider that provides a TransportChannel through a supplied InstantiatingGrpcChannelProvider. */
3434
@InternalApi
3535
public final class BigtableTransportChannelProvider implements TransportChannelProvider {
3636

@@ -101,6 +101,7 @@ public TransportChannelProvider withPoolSize(int size) {
101101
return new BigtableTransportChannelProvider(newChannelProvider);
102102
}
103103

104+
/**Expected to only be called once when BigtableClientContext is created*/
104105
@Override
105106
public TransportChannel getTransportChannel() throws IOException {
106107
// This provider's main purpose is to replace the default GAX ChannelPool
@@ -148,7 +149,7 @@ public TransportChannelProvider withCredentials(Credentials credentials) {
148149
return new BigtableTransportChannelProvider(newChannelProvider);
149150
}
150151

151-
/** Creates a FixedTransportChannelProvider. */
152+
/** Creates a BigtableTransportChannelProvider. */
152153
public static BigtableTransportChannelProvider create(
153154
InstantiatingGrpcChannelProvider instantiatingGrpcChannelProvider) {
154155
return new BigtableTransportChannelProvider(instantiatingGrpcChannelProvider);

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolSettingsTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,12 @@
99
import java.util.Arrays;
1010
import java.util.Set;
1111
import java.util.stream.Collectors;
12-
import org.junit.Rule;
1312
import org.junit.Test;
1413
import org.junit.runner.RunWith;
1514
import org.junit.runners.JUnit4;
16-
import org.mockito.junit.MockitoJUnit;
17-
import org.mockito.junit.MockitoRule;
1815

1916
@RunWith(JUnit4.class)
2017
public class BigtableChannelPoolSettingsTest {
21-
@Rule public MockitoRule mockitoRule = MockitoJUnit.rule();
2218

2319
@Test
2420
public void testToBigtableChannelPoolSettingsAllFieldsSetCopiesCorrectly() throws Exception {

0 commit comments

Comments
 (0)