Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 55dda42

Browse files
fix tests & address feedback
Change-Id: I44e660ab37999be0e98f71db3c089df03c123aad
1 parent 95a9a3f commit 55dda42

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactoryTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,8 @@ public void testCreateWithRefreshingChannel() throws Exception {
259259
BigtableDataSettings.newBuilderForEmulator(server.getPort())
260260
.setProjectId(DEFAULT_PROJECT_ID)
261261
.setInstanceId(DEFAULT_INSTANCE_ID)
262-
.setAppProfileId(DEFAULT_APP_PROFILE_ID);
262+
.setAppProfileId(DEFAULT_APP_PROFILE_ID)
263+
.setRefreshingChannel(true);
263264
builder
264265
.stubSettings()
265266
.setCredentialsProvider(credentialsProvider)

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/BuiltinMetricsTracerTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -508,9 +508,11 @@ public void onComplete() {
508508
public void testReadRowsApplicationLatencyWithManualFlowControl() throws Exception {
509509
int counter = 0;
510510

511-
for (Row ignored : stub.readRowsCallable().call(Query.create(TableId.of(TABLE)))) {
511+
Iterator<Row> rows = stub.readRowsCallable().call(Query.create(TableId.of(TABLE))).iterator();
512+
while (rows.hasNext()) {
512513
counter++;
513514
Thread.sleep(APPLICATION_LATENCY);
515+
rows.next();
514516
}
515517

516518
MetricData applicationLatency =

0 commit comments

Comments
 (0)