Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 87fe788

Browse files
committed
Comments on default instance
1 parent 7f6a828 commit 87fe788

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/CbtTestProxy.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,7 @@ public void bulkMutateRows(
373373

374374
responseObserver.onNext(
375375
MutateRowsResult.newBuilder()
376+
// Note that the default instance == OK
376377
.setStatus(com.google.rpc.Status.getDefaultInstance())
377378
.build());
378379
responseObserver.onCompleted();
@@ -406,6 +407,7 @@ public void readRow(ReadRowRequest request, StreamObserver<RowResult> responseOb
406407
if (row != null) {
407408
RowResult.Builder resultBuilder = convertRowResult(row);
408409
responseObserver.onNext(
410+
// Note that the default instance == OK
409411
resultBuilder.setStatus(com.google.rpc.Status.getDefaultInstance()).build());
410412
} else {
411413
logger.info(String.format("readRow() did not find row: %s", request.getRowKey()));
@@ -463,6 +465,7 @@ public void readRows(ReadRowsRequest request, StreamObserver<RowsResult> respons
463465
int cancelAfterRows = request.getCancelAfterRows();
464466
RowsResult.Builder resultBuilder = convertRowsResult(rows, cancelAfterRows);
465467
responseObserver.onNext(
468+
// Note that the default instance == OK
466469
resultBuilder.setStatus(com.google.rpc.Status.getDefaultInstance()).build());
467470
} catch (ApiException e) {
468471
responseObserver.onNext(
@@ -618,6 +621,7 @@ public void sampleRowKeys(
618621
.setOffsetBytes(keyOffset.getOffsetBytes());
619622
}
620623
responseObserver.onNext(
624+
// Note that the default instance == OK
621625
resultBuilder.setStatus(com.google.rpc.Status.getDefaultInstance()).build());
622626
responseObserver.onCompleted();
623627
}
@@ -660,6 +664,7 @@ public void checkAndMutateRow(
660664
CheckAndMutateRowResult.Builder resultBuilder = CheckAndMutateRowResult.newBuilder();
661665
resultBuilder.getResultBuilder().setPredicateMatched(matched);
662666
responseObserver.onNext(
667+
// Note that the default instance == OK
663668
resultBuilder.setStatus(com.google.rpc.Status.getDefaultInstance()).build());
664669
responseObserver.onCompleted();
665670
}
@@ -682,12 +687,14 @@ public void readModifyWriteRow(
682687
if (row != null) {
683688
RowResult.Builder resultBuilder = convertRowResult(row);
684689
responseObserver.onNext(
690+
// Note that the default instance == OK
685691
resultBuilder.setStatus(com.google.rpc.Status.getDefaultInstance()).build());
686692
} else {
687693
logger.info(
688694
String.format(
689695
"readModifyWriteRow() did not find row: %s", request.getRequest().getRowKey()));
690696
responseObserver.onNext(
697+
// Note that the default instance == OK
691698
RowResult.newBuilder().setStatus(com.google.rpc.Status.getDefaultInstance()).build());
692699
}
693700
} catch (ApiException e) {

0 commit comments

Comments
 (0)