Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 8a35ede

Browse files
remove replaced location & gfe methods
Change-Id: I2aff3f13f2f07b400d6f2099b75c9f1462077e44
1 parent 729f9be commit 8a35ede

3 files changed

Lines changed: 7 additions & 79 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracer.java

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,6 @@ public int getAttempt() {
7171
return attempt;
7272
}
7373

74-
/**
75-
* Record the latency between Google's network receives the RPC and reads back the first byte of
76-
* the response from server-timing header. If server-timing header is missing, increment the
77-
* missing header count.
78-
*
79-
* @deprecated Use {@link #setSidebandData(MetadataExtractorInterceptor.SidebandData)}
80-
*/
81-
@Deprecated
82-
public void recordGfeMetadata(@Nullable Long latency, @Nullable Throwable throwable) {
83-
// noop
84-
}
85-
8674
/** Adds an annotation of the total throttled time of a batch. */
8775
public void batchRequestThrottled(long throttledTimeMs) {
8876
// noop
@@ -92,31 +80,6 @@ public void setSidebandData(MetadataExtractorInterceptor.SidebandData sidebandDa
9280
// noop
9381
}
9482

95-
/**
96-
* Set the Bigtable zone and cluster so metrics can be tagged with location information. This will
97-
* be called in BuiltinMetricsTracer.
98-
*
99-
* @deprecated Use {@link #setSidebandData(MetadataExtractorInterceptor.SidebandData)}
100-
*/
101-
@Deprecated
102-
public void setLocations(String zone, String cluster) {}
103-
104-
/**
105-
* Set the underlying transport used to process the attempt
106-
*
107-
* @deprecated Use {@link #setSidebandData(MetadataExtractorInterceptor.SidebandData)}
108-
*/
109-
@Deprecated
110-
public void setTransportAttrs(BuiltinMetricsTracer.TransportAttrs attrs) {}
111-
112-
@Deprecated
113-
/**
114-
* @deprecated {@link #grpcMessageSent()} is called instead.
115-
*/
116-
public void grpcChannelQueuedLatencies(long queuedTimeMs) {
117-
// noop
118-
}
119-
12083
/** Called when the message is sent on a grpc channel. */
12184
public void grpcMessageSent() {
12285
// noop

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/CompositeTracer.java

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -198,34 +198,13 @@ public int getAttempt() {
198198
return attempt;
199199
}
200200

201-
@Override
202-
public void recordGfeMetadata(@Nullable Long latency, @Nullable Throwable throwable) {
203-
for (BigtableTracer tracer : bigtableTracers) {
204-
tracer.recordGfeMetadata(latency, throwable);
205-
}
206-
}
207-
208201
@Override
209202
public void batchRequestThrottled(long throttledTimeMs) {
210203
for (BigtableTracer tracer : bigtableTracers) {
211204
tracer.batchRequestThrottled(throttledTimeMs);
212205
}
213206
}
214207

215-
@Override
216-
public void setLocations(String zone, String cluster) {
217-
for (BigtableTracer tracer : bigtableTracers) {
218-
tracer.setLocations(zone, cluster);
219-
}
220-
}
221-
222-
@Override
223-
public void setTransportAttrs(BuiltinMetricsTracer.TransportAttrs attrs) {
224-
for (BigtableTracer tracer : bigtableTracers) {
225-
tracer.setTransportAttrs(attrs);
226-
}
227-
}
228-
229208
@Override
230209
public void setSidebandData(MetadataExtractorInterceptor.SidebandData sidebandData) {
231210
for (BigtableTracer bigtableTracer : bigtableTracers) {
@@ -254,13 +233,6 @@ public void afterResponse(long applicationLatency) {
254233
}
255234
}
256235

257-
@Override
258-
public void grpcChannelQueuedLatencies(long queuedTimeMs) {
259-
for (BigtableTracer tracer : bigtableTracers) {
260-
tracer.grpcChannelQueuedLatencies(queuedTimeMs);
261-
}
262-
}
263-
264236
@Override
265237
public void grpcMessageSent() {
266238
for (BigtableTracer tracer : bigtableTracers) {

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/CompositeTracerTest.java

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@
2525
import com.google.api.gax.tracing.ApiTracer;
2626
import com.google.api.gax.tracing.ApiTracer.Scope;
2727
import com.google.bigtable.v2.ReadRowsRequest;
28+
import com.google.cloud.bigtable.data.v2.stub.MetadataExtractorInterceptor;
2829
import com.google.cloud.bigtable.misc_utilities.MethodComparator;
2930
import com.google.common.collect.ImmutableList;
30-
import io.grpc.Status;
31-
import io.grpc.StatusRuntimeException;
3231
import java.lang.reflect.Method;
3332
import java.util.Arrays;
3433
import org.junit.Assert;
@@ -241,11 +240,12 @@ public void testGetAttempt() {
241240
}
242241

243242
@Test
244-
public void testRecordGfeLatency() {
245-
Throwable t = new StatusRuntimeException(Status.UNAVAILABLE);
246-
compositeTracer.recordGfeMetadata(20L, t);
247-
verify(child3, times(1)).recordGfeMetadata(20L, t);
248-
verify(child4, times(1)).recordGfeMetadata(20L, t);
243+
public void testSidebandData() {
244+
MetadataExtractorInterceptor.SidebandData sidebandData =
245+
new MetadataExtractorInterceptor.SidebandData();
246+
compositeTracer.setSidebandData(sidebandData);
247+
verify(child3, times(1)).setSidebandData(sidebandData);
248+
verify(child4, times(1)).setSidebandData(sidebandData);
249249
}
250250

251251
@Test
@@ -264,13 +264,6 @@ public void testMethodsOverride() {
264264
.containsAtLeastElementsIn(baseMethods);
265265
}
266266

267-
@Test
268-
public void testRequestBlockedOnChannel() {
269-
compositeTracer.grpcChannelQueuedLatencies(5L);
270-
verify(child3, times(1)).grpcChannelQueuedLatencies(5L);
271-
verify(child4, times(1)).grpcChannelQueuedLatencies(5L);
272-
}
273-
274267
@Test
275268
public void testGrpcMessageSent() {
276269
compositeTracer.grpcMessageSent();

0 commit comments

Comments
 (0)