Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 900c134

Browse files
more tweaks
Change-Id: Ia1f48d96c0bb2cfd0596629de87c8015c330276d
1 parent 55dda42 commit 900c134

5 files changed

Lines changed: 10 additions & 8 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Backup.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ public EncryptionInfo getEncryptionInfo() {
223223
return EncryptionInfo.fromProto(proto.getEncryptionInfo());
224224
}
225225

226-
@SuppressWarnings("EqualsIncompatibleType")
226+
@SuppressWarnings("EqualsGetClass")
227227
@Override
228228
public boolean equals(Object o) {
229229
if (this == o) {

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1783,10 +1783,9 @@ public Batcher<RowMutationEntry, Void> newBulkMutationBatcher(@Nonnull String ta
17831783
* GrpcCallContext)} instead.
17841784
*/
17851785
@Deprecated
1786-
@BetaApi("This surface is likely to change as the batching surface evolves.")
17871786
public Batcher<RowMutationEntry, Void> newBulkMutationBatcher(
17881787
@Nonnull String tableId, @Nullable GrpcCallContext ctx) {
1789-
return stub.newMutateRowsBatcher(tableId, ctx);
1788+
return stub.newMutateRowsBatcher(TableId.of(tableId), ctx);
17901789
}
17911790

17921791
/**

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -730,7 +730,10 @@ private UnaryCallable<BulkMutation, MutateRowsAttemptResult> createMutateRowsBas
730730
* com.google.cloud.bigtable.data.v2.models.MutateRowsException}.
731731
* <li>Split the responses using {@link MutateRowsBatchingDescriptor}.
732732
* </ul>
733+
*
734+
* @deprecated Please use {@link #newMutateRowsBatcher(TargetId, GrpcCallContext)}
733735
*/
736+
@Deprecated
734737
public Batcher<RowMutationEntry, Void> newMutateRowsBatcher(
735738
@Nonnull String tableId, @Nullable GrpcCallContext ctx) {
736739
return new BatcherImpl<>(

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1629,7 +1629,7 @@ public void testSetIamPolicy() {
16291629
.isEqualTo(
16301630
Policy.newBuilder()
16311631
.addIdentity(Role.of("bigtable.viewer"), Identity.user("someone@example.com"))
1632-
.setEtag(BaseEncoding.base64().encode("my-etag".getBytes()))
1632+
.setEtag(BaseEncoding.base64().encode("my-etag".getBytes(StandardCharsets.UTF_8)))
16331633
.build());
16341634
}
16351635

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@
7171
import com.google.protobuf.AbstractMessage;
7272
import com.google.protobuf.Empty;
7373
import io.grpc.stub.StreamObserver;
74+
import java.util.ArrayDeque;
7475
import java.util.ArrayList;
75-
import java.util.LinkedList;
7676
import java.util.List;
7777
import java.util.Queue;
7878
import javax.annotation.Generated;
@@ -85,7 +85,7 @@ public class MockBigtableTableAdminImpl extends BigtableTableAdminImplBase {
8585

8686
public MockBigtableTableAdminImpl() {
8787
requests = new ArrayList<>();
88-
responses = new LinkedList<>();
88+
responses = new ArrayDeque<>();
8989
}
9090

9191
public List<AbstractMessage> getRequests() {
@@ -97,7 +97,7 @@ public void addResponse(AbstractMessage response) {
9797
}
9898

9999
public void setResponses(List<AbstractMessage> responses) {
100-
this.responses = new LinkedList<Object>(responses);
100+
this.responses = new ArrayDeque<>(responses);
101101
}
102102

103103
public void addException(Exception exception) {
@@ -106,7 +106,7 @@ public void addException(Exception exception) {
106106

107107
public void reset() {
108108
requests = new ArrayList<>();
109-
responses = new LinkedList<>();
109+
responses = new ArrayDeque<>();
110110
}
111111

112112
@Override

0 commit comments

Comments
 (0)