Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 973cca1

Browse files
committed
fix 1
1 parent 0cabccd commit 973cca1

4 files changed

Lines changed: 5 additions & 7 deletions

File tree

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
3030
<dependency>
3131
<groupId>com.google.cloud</groupId>
3232
<artifactId>google-cloud-bigtable</artifactId>
33-
<version>2.77.2-SNAPSHOT</version>
3433
</dependency>
3534

3635
```

samples/snippets/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
<dependency>
4343
<groupId>com.google.cloud</groupId>
4444
<artifactId>google-cloud-bigtable</artifactId>
45-
<version>2.77.2-SNAPSHOT</version>
4645
</dependency>
4746
<!-- [END bigtable_install_with_bom] -->
4847

samples/snippets/src/test/java/com/example/bigtable/InstanceAdminExampleTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public void setup() throws Exception {
102102
@After
103103
public void after() {
104104
if (exists(instanceId)) {
105-
adminClient.deleteInstance(instanceId);
105+
adminClient.deleteInstance("projects/" + projectId + "/instances/" + instanceId);
106106
}
107107
if (instanceAdmin != null) {
108108
instanceAdmin.close();

samples/snippets/src/test/java/com/example/bigtable/TableAdminExampleTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,10 @@ private boolean ruleCheck(GCRule condition) {
204204
.build();
205205
for (com.google.bigtable.admin.v2.ColumnFamily columnFamily :
206206
adminClient.getTable(request).getColumnFamiliesMap().values()) {
207-
// In a real test, we would convert GCRule to com.google.bigtable.admin.v2.GcRule and compare,
208-
// but for this snippet we'll just return true to pass the compilation.
209-
found = true;
210-
break;
207+
if (columnFamily.getGcRule().equals(condition.toProto())) {
208+
found = true;
209+
break;
210+
}
211211
}
212212
return found;
213213
}

0 commit comments

Comments
 (0)