Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 9c56423

Browse files
committed
fix: populate table id for materialized view
1 parent 108125b commit 9c56423

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.google.bigtable.v2.AuthorizedViewName;
2727
import com.google.bigtable.v2.CheckAndMutateRowRequest;
2828
import com.google.bigtable.v2.GenerateInitialChangeStreamPartitionsRequest;
29+
import com.google.bigtable.v2.MaterializedViewName;
2930
import com.google.bigtable.v2.MutateRowRequest;
3031
import com.google.bigtable.v2.MutateRowsRequest;
3132
import com.google.bigtable.v2.ReadChangeStreamRequest;
@@ -121,9 +122,11 @@ static TagValue extractStatusFromFuture(Future<?> future) {
121122
static String extractTableId(Object request) {
122123
String tableName = null;
123124
String authorizedViewName = null;
125+
String materializedViewName = null;
124126
if (request instanceof ReadRowsRequest) {
125127
tableName = ((ReadRowsRequest) request).getTableName();
126128
authorizedViewName = ((ReadRowsRequest) request).getAuthorizedViewName();
129+
materializedViewName = ((ReadRowsRequest) request).getMaterializedViewName();
127130
} else if (request instanceof MutateRowsRequest) {
128131
tableName = ((MutateRowsRequest) request).getTableName();
129132
authorizedViewName = ((MutateRowsRequest) request).getAuthorizedViewName();
@@ -133,6 +136,7 @@ static String extractTableId(Object request) {
133136
} else if (request instanceof SampleRowKeysRequest) {
134137
tableName = ((SampleRowKeysRequest) request).getTableName();
135138
authorizedViewName = ((SampleRowKeysRequest) request).getAuthorizedViewName();
139+
materializedViewName = ((SampleRowKeysRequest) request).getMaterializedViewName();
136140
} else if (request instanceof CheckAndMutateRowRequest) {
137141
tableName = ((CheckAndMutateRowRequest) request).getTableName();
138142
authorizedViewName = ((CheckAndMutateRowRequest) request).getAuthorizedViewName();
@@ -150,6 +154,9 @@ static String extractTableId(Object request) {
150154
if (authorizedViewName != null && !authorizedViewName.isEmpty()) {
151155
return AuthorizedViewName.parse(authorizedViewName).getTable();
152156
}
157+
if (materializedViewName != null && !materializedViewName.isEmpty()) {
158+
return MaterializedViewName.parse(materializedViewName).getMaterializedView();
159+
}
153160
return "<unspecified>";
154161
}
155162

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableMaterializedViewIT.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ public static void createInstance() throws IOException {
7878
Instance instance =
7979
client.createInstance(
8080
CreateInstanceRequest.of(new PrefixGenerator().newPrefix())
81+
.setDisplayName("BigtableMaterializedViewIT")
8182
.addCluster("my-cluster", "us-east1-c", 3, StorageType.SSD));
8283
instanceId = instance.getId();
8384
tableAdminClient =

0 commit comments

Comments
 (0)