chore: internalize converters in the metrics exporter (#2804)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Rollback plan is reviewed and LGTMed
- [ ] All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).

Author: igorbernstein2

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java

@@ -124,8 +124,7 @@ public static BigtableClientContext create(
       if (settings.areInternalMetricsEnabled()) {
         builtinOtel =
             Util.createBuiltinOtel(
-                InstanceName.of(settings.getProjectId(), settings.getInstanceId()),
-                settings.getAppProfileId(),
+                clientInfo,
                 credentials,
                 settings.getMetricsEndpoint(),
                 universeDomain,

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java

@@ -39,11 +39,13 @@
 import com.google.api.gax.core.NoCredentialsProvider;
 import com.google.api.gax.rpc.PermissionDeniedException;
 import com.google.auth.Credentials;
+import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
 import com.google.cloud.monitoring.v3.MetricServiceClient;
 import com.google.cloud.monitoring.v3.MetricServiceSettings;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Preconditions;
 import com.google.common.base.Supplier;
+import com.google.common.base.Suppliers;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
@@ -112,10 +114,10 @@ public final class BigtableCloudMonitoringExporter implements MetricExporter {
   private final AtomicBoolean exportFailureLogged = new AtomicBoolean(false);
 
   static BigtableCloudMonitoringExporter create(
+      ClientInfo clientInfo,
       @Nullable Credentials credentials,
       @Nullable String endpoint,
       String universeDomain,
-      List<TimeSeriesConverter> converters,
       @Nullable ScheduledExecutorService executorService)
       throws IOException {
     Preconditions.checkNotNull(universeDomain);
@@ -152,6 +154,13 @@ static BigtableCloudMonitoringExporter create(
     // it as not retried for now.
     settingsBuilder.createServiceTimeSeriesSettings().setSimpleTimeoutNoRetriesDuration(timeout);
 
+    ImmutableList<TimeSeriesConverter> converters =
+        ImmutableList.of(
+            new PublicTimeSeriesConverter(),
+            new InternalTimeSeriesConverter(
+                Suppliers.memoize(
+                    () -> BigtableExporterUtils.createInternalMonitoredResource(clientInfo))));
+
     return new BigtableCloudMonitoringExporter(
         MetricServiceClient.create(settingsBuilder.build()), converters);
   }

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java

@@ -38,8 +38,8 @@
 import com.google.api.Distribution;
 import com.google.api.Metric;
 import com.google.api.MonitoredResource;
-import com.google.bigtable.v2.InstanceName;
 import com.google.cloud.bigtable.Version;
+import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
 import com.google.cloud.opentelemetry.detection.AttributeKeys;
 import com.google.cloud.opentelemetry.detection.DetectedPlatform;
 import com.google.cloud.opentelemetry.detection.GCPPlatformDetector;
@@ -182,10 +182,9 @@ static List<TimeSeries> convertToApplicationResourceTimeSeries(
   }
 
   @Nullable
-  static MonitoredResource createInternalMonitoredResource(
-      InstanceName instanceName, String appProfileId) {
+  static MonitoredResource createInternalMonitoredResource(ClientInfo clientInfo) {
     try {
-      MonitoredResource monitoredResource = detectResource(instanceName, appProfileId);
+      MonitoredResource monitoredResource = detectResource(clientInfo);
       logger.log(Level.FINE, "Internal metrics monitored resource: %s", monitoredResource);
       return monitoredResource;
     } catch (Exception e) {
@@ -198,7 +197,7 @@ static MonitoredResource createInternalMonitoredResource(
   }
 
   @Nullable
-  private static MonitoredResource detectResource(InstanceName instanceName, String appProfileId) {
+  private static MonitoredResource detectResource(ClientInfo clientInfo) {
     GCPPlatformDetector detector = GCPPlatformDetector.DEFAULT_INSTANCE;
     DetectedPlatform detectedPlatform = detector.detectPlatform();
 
@@ -245,9 +244,9 @@ private static MonitoredResource detectResource(InstanceName instanceName, Strin
 
     return MonitoredResource.newBuilder()
         .setType("bigtable_client")
-        .putLabels("project_id", instanceName.getProject())
-        .putLabels("instance", instanceName.getInstance())
-        .putLabels("app_profile", appProfileId)
+        .putLabels("project_id", clientInfo.getInstanceName().getProject())
+        .putLabels("instance", clientInfo.getInstanceName().getInstance())
+        .putLabels("app_profile", clientInfo.getAppProfileId())
         .putLabels("client_project", detectedPlatform.getProjectId())
         .putLabels("region", region)
         .putLabels("cloud_platform", cloud_platform)

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java

@@ -27,7 +27,6 @@
 import com.google.bigtable.v2.AuthorizedViewName;
 import com.google.bigtable.v2.CheckAndMutateRowRequest;
 import com.google.bigtable.v2.GenerateInitialChangeStreamPartitionsRequest;
-import com.google.bigtable.v2.InstanceName;
 import com.google.bigtable.v2.MaterializedViewName;
 import com.google.bigtable.v2.MutateRowRequest;
 import com.google.bigtable.v2.MutateRowsRequest;
@@ -42,8 +41,6 @@
 import com.google.cloud.bigtable.data.v2.BigtableDataSettings;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
 import com.google.cloud.bigtable.data.v2.stub.MetadataExtractorInterceptor;
-import com.google.common.base.Suppliers;
-import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import io.grpc.Metadata;
 import io.grpc.Status;
@@ -162,8 +159,7 @@ static Map<String, List<String>> createStatsHeaders(ApiCallContext apiCallContex
   }
 
   public static OpenTelemetrySdk createBuiltinOtel(
-      InstanceName instanceName,
-      String appProfileId,
+      ClientInfo clientInfo,
       @Nullable Credentials defaultCredentials,
       @Nullable String metricsEndpoint,
       String universeDomain,
@@ -189,17 +185,7 @@ public static OpenTelemetrySdk createBuiltinOtel(
 
     MetricExporter publicExporter =
         BigtableCloudMonitoringExporter.create(
-            credentials,
-            metricsEndpoint,
-            universeDomain,
-            ImmutableList.of(
-                new BigtableCloudMonitoringExporter.PublicTimeSeriesConverter(),
-                new BigtableCloudMonitoringExporter.InternalTimeSeriesConverter(
-                    Suppliers.memoize(
-                        () ->
-                            BigtableExporterUtils.createInternalMonitoredResource(
-                                instanceName, appProfileId)))),
-            executor);
+            clientInfo, credentials, metricsEndpoint, universeDomain, executor);
     PeriodicMetricReaderBuilder readerBuilder =
         PeriodicMetricReader.builder(publicExporter).setExecutor(executor);
     meterProvider.registerMetricReader(readerBuilder.build());
@@ -274,7 +260,8 @@ public static ApiTracerFactory createOCMetricsFactory(
   }
 
   public static BuiltinMetricsTracerFactory createOtelMetricsFactory(
-      OpenTelemetry otel, ClientInfo clientInfo) {
-    return new BuiltinMetricsTracerFactory(otel, clientInfo);
+      OpenTelemetry otel, ClientInfo clientInfo) throws IOException {
+
+    return BuiltinMetricsTracerFactory.create(otel, clientInfo);
   }
 }