chore: clean up warnings pass 3 (#2847)

suppress warnings for refreshing channel, the usages cant be removed currently

Author: igorbernstein2

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java

@@ -119,27 +119,31 @@ public static Builder newBuilderForEmulator(int port) {
    * port number.
    */
   public static Builder newBuilderForEmulator(String hostname, int port) {
-    Builder builder = new Builder();
-
-    builder
-        .stubSettings()
-        .setCredentialsProvider(NoCredentialsProvider.create())
-        .setEndpoint(hostname + ":" + port)
-        // disable channel refreshing when creating an emulator
-        .setRefreshingChannel(false)
-        .setMetricsProvider(NoopMetricsProvider.INSTANCE) // disable exporting metrics for emulator
-        .disableInternalMetrics()
-        .setTransportChannelProvider(
-            InstantiatingGrpcChannelProvider.newBuilder()
-                .setMaxInboundMessageSize(256 * 1024 * 1024)
-                .setChannelPoolSettings(ChannelPoolSettings.staticallySized(1))
-                .setChannelConfigurator(ManagedChannelBuilder::usePlaintext)
-                .setKeepAliveTimeDuration(
-                    java.time.Duration.ofSeconds(61)) // sends ping in this interval
-                .setKeepAliveTimeoutDuration(
-                    java.time.Duration.ofSeconds(
-                        10)) // wait this long before considering the connection dead
-                .build());
+    BigtableDataSettings.Builder builder = new BigtableDataSettings.Builder();
+
+    // TODO: remove the suppression once setRefreshingChannel is no longer necessary
+    @SuppressWarnings({"deprecation", "VariableUnused"})
+    EnhancedBigtableStubSettings.Builder ignored =
+        builder
+            .stubSettings()
+            .setCredentialsProvider(NoCredentialsProvider.create())
+            .setEndpoint(hostname + ":" + port)
+            // disable channel refreshing when creating an emulator
+            .setRefreshingChannel(false)
+            .setMetricsProvider(
+                NoopMetricsProvider.INSTANCE) // disable exporting metrics for emulator
+            .disableInternalMetrics()
+            .setTransportChannelProvider(
+                InstantiatingGrpcChannelProvider.newBuilder()
+                    .setMaxInboundMessageSize(256 * 1024 * 1024)
+                    .setChannelPoolSettings(ChannelPoolSettings.staticallySized(1))
+                    .setChannelConfigurator(ManagedChannelBuilder::usePlaintext)
+                    .setKeepAliveTimeDuration(
+                        java.time.Duration.ofSeconds(61)) // sends ping in this interval
+                    .setKeepAliveTimeoutDuration(
+                        java.time.Duration.ofSeconds(
+                            10)) // wait this long before considering the connection dead
+                    .build());
 
     LOGGER.info("Connecting to the Bigtable emulator at " + hostname + ":" + port);
     return builder;

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java

@@ -151,7 +151,7 @@ public static BigtableClientContext create(
       ChannelPrimer channelPrimer = NoOpChannelPrimer.create();
 
       // Inject channel priming if enabled
-      if (builder.isRefreshingChannel()) {
+      if (isRefreshingEnabled(builder)) {
         channelPrimer =
             BigtableChannelPrimer.create(
                 builder.getProjectId(),
@@ -182,6 +182,11 @@ public static BigtableClientContext create(
     }
   }
 
+  @SuppressWarnings("deprecation")
+  private static boolean isRefreshingEnabled(EnhancedBigtableStubSettings.Builder b) {
+    return b.isRefreshingChannel();
+  }
+
   private static void configureGrpcOtel(
       InstantiatingGrpcChannelProvider.Builder transportProvider, Metrics metrics) {
     @SuppressWarnings("rawtypes")

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactoryTest.java

@@ -255,6 +255,8 @@ public void testCreateForInstanceWithAppProfileHasCorrectSettings() throws Excep
   @Test
   public void testCreateWithRefreshingChannel() throws Exception {
     int poolSize = 3;
+    // TODO: remove the suppression when setRefreshingChannel can be removed
+    @SuppressWarnings("deprecation")
     BigtableDataSettings.Builder builder =
         BigtableDataSettings.newBuilderForEmulator(server.getPort())
             .setProjectId(DEFAULT_PROJECT_ID)

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BigtableDataSettingsTest.java

@@ -27,6 +27,8 @@ public class BigtableDataSettingsTest {
 
   @Test
   public void testToString() {
+    // TODO: figure out how avoid using setRefreshingChannel
+    @SuppressWarnings("deprecation")
     BigtableDataSettings settings =
         BigtableDataSettings.newBuilder()
             .setProjectId("our-project-2-12")

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/PreparedStatementImplTest.java

@@ -80,6 +80,7 @@ public class PreparedStatementImplTest {
   public void setUp() throws IOException {
     service = new TestBigtableSqlService();
     serverRule.getServiceRegistry().addService(service);
+
     BigtableDataSettings.Builder settings =
         BigtableDataSettings.newBuilder()
             .setProjectId(TestBigtableSqlService.DEFAULT_PROJECT_ID)
@@ -91,8 +92,6 @@ public void setUp() throws IOException {
         .setTransportChannelProvider(
             FixedTransportChannelProvider.create(
                 GrpcTransportChannel.create(serverRule.getChannel())))
-        // Refreshing channel doesn't work with FixedTransportChannelProvider
-        .setRefreshingChannel(false)
         .build();
     // Remove log noise from client side metrics
     settings.setMetricsProvider(NoopMetricsProvider.INSTANCE).disableInternalMetrics();

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/BuiltinMetricsTracerTest.java

@@ -234,7 +234,6 @@ public void sendHeaders(Metadata headers) {
             .setProjectId(PROJECT_ID)
             .setInstanceId(INSTANCE_ID)
             .setAppProfileId(APP_PROFILE_ID)
-            .setRefreshingChannel(false)
             .build();
     EnhancedBigtableStubSettings.Builder stubSettingsBuilder =
         settings.getStubSettings().toBuilder();

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubCloseRetryTest.java

@@ -68,8 +68,7 @@ public void setUp() throws Exception {
         BigtableDataSettings.newBuilderForEmulator(server.getPort())
             .setProjectId(PROJECT_ID)
             .setInstanceId(INSTANCE_ID)
-            .setCredentialsProvider(NoCredentialsProvider.create())
-            .setRefreshingChannel(false);
+            .setCredentialsProvider(NoCredentialsProvider.create());
 
     stub = EnhancedBigtableStub.create(settingBuilder.build().getStubSettings());
   }

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettingsTest.java

@@ -55,6 +55,7 @@
 import org.threeten.bp.Duration;
 
 @RunWith(JUnit4.class)
+@SuppressWarnings("deprecation") // TODO: remove this
 public class EnhancedBigtableStubSettingsTest {
   @Test
   public void instanceNameIsRequiredTest() {

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubTest.java

@@ -261,6 +261,8 @@ public void testBatchJwtAudience()
     ManagedChannel channel =
         ManagedChannelBuilder.forAddress("localhost", server.getPort()).usePlaintext().build();
 
+    // TODO: remove this suppression when setRefreshingChannel can be removed
+    @SuppressWarnings("deprecation")
     EnhancedBigtableStubSettings settings =
         EnhancedBigtableStubSettings.newBuilder()
             .setProjectId("fake-project")
@@ -311,8 +313,9 @@ public void testFeatureFlags() throws InterruptedException, IOException, Executi
   }
 
   @Test
-  public void testPingAndWarmFeatureFlags()
-      throws InterruptedException, IOException, ExecutionException {
+  public void testPingAndWarmFeatureFlags() throws InterruptedException, IOException {
+    // TODO: remove the suppression once setRefreshingChannel can be removed
+    @SuppressWarnings("deprecation")
     EnhancedBigtableStubSettings settings =
         defaultSettings.toBuilder().setRefreshingChannel(true).build();
     try (EnhancedBigtableStub ignored = EnhancedBigtableStub.create(settings)) {
@@ -543,6 +546,8 @@ public void testCreateReadRowsRawCallable() throws InterruptedException {
 
   @Test
   public void testChannelPrimerConfigured() throws IOException {
+    // TODO: remove the suppression once setRefreshingChannel can be removed
+    @SuppressWarnings("deprecation")
     EnhancedBigtableStubSettings settings =
         defaultSettings.toBuilder().setRefreshingChannel(true).build();
 
@@ -712,8 +717,7 @@ public void testBulkMutationFlowControllerConfigured() throws Exception {
   @Test
   public void testCallContextPropagatedInMutationBatcher()
       throws IOException, InterruptedException, ExecutionException {
-    EnhancedBigtableStubSettings settings =
-        defaultSettings.toBuilder().setRefreshingChannel(true).build();
+    EnhancedBigtableStubSettings settings = defaultSettings.toBuilder().build();
 
     try (EnhancedBigtableStub stub = EnhancedBigtableStub.create(settings)) {
       // clear the previous contexts
@@ -739,8 +743,7 @@ public void testCallContextPropagatedInMutationBatcher()
   @Test
   public void testCallContextPropagatedInReadBatcher()
       throws IOException, InterruptedException, ExecutionException {
-    EnhancedBigtableStubSettings settings =
-        defaultSettings.toBuilder().setRefreshingChannel(true).build();
+    EnhancedBigtableStubSettings settings = defaultSettings.toBuilder().build();
 
     try (EnhancedBigtableStub stub = EnhancedBigtableStub.create(settings)) {
       // clear the previous contexts

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/RetryInfoTest.java

@@ -139,8 +139,7 @@ public void close(Status status, Metadata trailers) {
     BigtableDataSettings.Builder settings =
         BigtableDataSettings.newBuilderForEmulator(server.getPort())
             .setProjectId("fake-project")
-            .setInstanceId("fake-instance")
-            .setRefreshingChannel(false);
+            .setInstanceId("fake-instance");
 
     this.client = BigtableDataClient.create(settings.build());
   }