Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit b8e3916

Browse files
committed
fix: address comments
1 parent 6fb1fab commit b8e3916

2 files changed

Lines changed: 5 additions & 20 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1460,25 +1460,6 @@ public ApiFuture<Void> awaitReplicationAsync(final String tableId) {
14601460
return stub.awaitReplicationCallable().futureCall(tableName);
14611461
}
14621462

1463-
/**
1464-
* Generates a consistency token and polls it until replication is consistent. Blocks until
1465-
* completion.
1466-
*
1467-
* @param tableId The table to check.
1468-
*/
1469-
public void waitForConsistency(String tableId) {
1470-
awaitReplication(tableId);
1471-
}
1472-
1473-
/**
1474-
* Asynchronously generates a token and polls until consistent.
1475-
*
1476-
* @param tableId The table to check.
1477-
*/
1478-
public ApiFuture<Void> waitForConsistencyAsync(String tableId) {
1479-
return awaitReplicationAsync(tableId);
1480-
}
1481-
14821463
/**
14831464
* Polls an existing consistency token until replication is consistent. Useful for checking
14841465
* consistency of a token generated in a separate process. Blocks until completion.

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyRequest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.bigtable.admin.v2.StandardReadRemoteWrites;
2424
import com.google.bigtable.admin.v2.TableName;
2525
import com.google.cloud.bigtable.data.v2.internal.TableAdminRequestContext;
26+
import com.google.common.base.Preconditions;
2627
import javax.annotation.Nonnull;
2728
import javax.annotation.Nullable;
2829

@@ -51,9 +52,12 @@ public static ConsistencyRequest forReplication(String tableId) {
5152
* Creates a request to check consistency using an existing token.
5253
*
5354
* @param tableId The table ID.
54-
* @param consistencyToken The token to check.
55+
* @param consistencyToken The token to check. Must not be null.
56+
* @throws NullPointerException if consistencyToken is null.
5557
*/
5658
public static ConsistencyRequest forReplication(String tableId, String consistencyToken) {
59+
Preconditions.checkNotNull(consistencyToken, "consistencyToken must not be null");
60+
5761
return new AutoValue_ConsistencyRequest(
5862
tableId, CheckConsistencyRequest.ModeCase.STANDARD_READ_REMOTE_WRITES, consistencyToken);
5963
}

0 commit comments

Comments
 (0)