Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit c6adaae

Browse files
committed
cleanup
Change-Id: I14bb659b6e390b50b0a8b43eba920864d0dc6ef3
1 parent 02583c3 commit c6adaae

1 file changed

Lines changed: 1 addition & 10 deletions

File tree

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/gaxx/utils/ChannelPoolCopyTest.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@ public void testToBigtableChannelPoolSettingsDefaultValuesCopiesCorrectly() thro
4646
assertSettingsCopiedCorrectly(originalSettings, copiedSettings);
4747
}
4848

49-
// @Test
50-
// public void testToBigtableChannelPoolSettingsNullInputReturnsNull() {
51-
// ChannelPoolSettings originalSettings = null;
52-
// BigtableChannelPoolSettings copiedSettings =
53-
// ChannelPoolSettingsCopier.toBigtableChannelPoolSettings(originalSettings);
54-
// assertThat(copiedSettings).isNull();
55-
// }
56-
5749
private void assertSettingsCopiedCorrectly(
5850
ChannelPoolSettings originalSettings, BigtableChannelPoolSettings copiedSettings)
5951
throws Exception {
@@ -80,8 +72,7 @@ private void assertSettingsCopiedCorrectly(
8072
.collect(Collectors.toSet());
8173

8274
// If this fails then we need to add support for the additional attributes on the gax
83-
// ChannelPool
84-
// Relevant things to update the copier and the other tests in this file
75+
// ChannelPool by updating the BigtableChannelPoolSettings.copyFrom method
8576
assertThat(supportedGetters).containsAtLeastElementsIn(actualGetters);
8677

8778
assertThat(originalSettings.getInitialChannelCount())

0 commit comments

Comments
 (0)