Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit c6b4518

Browse files
committed
remove onVRpcStarted
Change-Id: I1064ff6be95987c994360119c832e9e55abe60e5
1 parent c38f0bf commit c6b4518

3 files changed

Lines changed: 3 additions & 8 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/SessionList.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public Optional<SessionHandle> checkoutSession(AfeHandle afeHandle) {
111111
handle -> {
112112
poolStats.readyCount--;
113113
poolStats.inUseCount++;
114-
114+
inUseSessions.add(handle);
115115
if (handle.afe.get().sessions.isEmpty()) {
116116
afesWithReadySessions.remove(afeHandle);
117117
}
@@ -194,11 +194,6 @@ void onSessionStarted() {
194194
poolStats.readyCount++;
195195
}
196196

197-
void onVRpcStarted() {
198-
// Pool stats and AFE list are updated in SessionList#checkoutSession
199-
inUseSessions.add(this);
200-
}
201-
202197
/**
203198
* The session is returned to the pool after use. This undoes what SessionList#checkoutSession
204199
*/

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/SessionPoolImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,6 @@ private <ReqT extends Message, RespT extends Message> VRpc<ReqT, RespT> newRealC
577577
return new ForwardingVRpc<ReqT, RespT>(handle.getSession().newCall(desc)) {
578578
@Override
579579
public void start(ReqT req, VRpcCallContext ctx, VRpcListener<RespT> listener) {
580-
handle.onVRpcStarted();
581580
final Stopwatch stopwatch = Stopwatch.createStarted();
582581
super.start(
583582
req,

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/SessionDeadlineTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import io.grpc.ServerCall;
3535
import io.grpc.ServerCallHandler;
3636
import io.grpc.ServerInterceptor;
37+
import io.grpc.netty.shaded.io.grpc.netty.NettyServerBuilder;
3738
import io.grpc.stub.StreamObserver;
3839
import java.io.IOException;
3940
import java.util.concurrent.ExecutionException;
@@ -52,7 +53,7 @@ public class SessionDeadlineTest {
5253
public void setUp() throws IOException {
5354
fakeDataService = new FakeDataService();
5455
server =
55-
io.grpc.netty.shaded.io.grpc.netty.NettyServerBuilder.forPort(0)
56+
NettyServerBuilder.forPort(0)
5657
.addService(fakeDataService)
5758
.intercept(new ResponseHeaderInterceptor())
5859
.build()

0 commit comments

Comments
 (0)