chore: clean up warnings pass 2

Change-Id: Iaff267ffb3ed336aa089d6033e3bb36442feefb8

Author: igorbernstein2

google-cloud-bigtable/pom.xml

@@ -427,7 +427,7 @@
                 <compilerArgs>
                   <arg>-XDcompilePolicy=simple</arg>
                   <arg>--should-stop=ifError=FLOW</arg>
-                  <arg>-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode -Xep:MissingSummary:OFF -Xep:InlineMeSuggester:OFF -Xep:AutoValueImmutableFields:OFF -Xep:ObjectEqualsForPrimitives:OFF</arg>
+                  <arg>-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode -Xep:MissingSummary:OFF -Xep:InlineMeSuggester:OFF -Xep:AutoValueImmutableFields:OFF -Xep:ObjectEqualsForPrimitives:OFF -Xep:JavaDurationGetSecondsToToSeconds:OFF</arg>
 
                   <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</arg>
                   <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</arg>

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/SubsetView.java

@@ -105,6 +105,7 @@ public com.google.bigtable.admin.v2.AuthorizedView.SubsetView toProto() {
   }
 
   @Override
+  @SuppressWarnings("EqualsGetClass")
   public boolean equals(Object o) {
     if (this == o) {
       return true;

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/Type.java

@@ -52,8 +52,9 @@ static Type fromProto(com.google.bigtable.admin.v2.Type source) {
         return Aggregate.fromProto(source.getAggregateType());
       case KIND_NOT_SET:
         return Raw.create();
+      default:
+        throw new UnsupportedOperationException();
     }
-    throw new UnsupportedOperationException();
   }
 
   /** The raw type denotes the absence of a type. */
@@ -204,8 +205,9 @@ static Encoding fromProto(com.google.bigtable.admin.v2.Type.Int64.Encoding sourc
             return BigEndianBytes.create();
           case ENCODING_NOT_SET:
             return BigEndianBytes.create();
+          default:
+            throw new UnsupportedOperationException();
         }
-        throw new UnsupportedOperationException();
       }
 
       @AutoValue

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/common/Type.java

@@ -306,6 +306,7 @@ public SqlType<?> getType(java.lang.String fieldName) {
     }
 
     @Override
+    @SuppressWarnings("EqualsGetClass")
     public boolean equals(Object obj) {
       if (this == obj) {
         return true;
@@ -457,12 +458,12 @@ public Code getCode() {
     }
 
     @Override
-    public java.lang.String toString() {
+    public final java.lang.String toString() {
       return getCode().name() + "{enum=" + getEnumName() + "}";
     }
 
     @Override
-    public boolean equals(Object o) {
+    public final boolean equals(Object o) {
       if (this == o) {
         return true;
       }
@@ -486,7 +487,7 @@ public boolean equals(Object o) {
     }
 
     @Override
-    public int hashCode() {
+    public final int hashCode() {
       T thisEnum = getForNumber().apply(0);
       if (thisEnum == null) {
         return getForNumber().hashCode();
@@ -561,6 +562,7 @@ public static SchemalessEnum create(
       return new AutoValue_Type_SchemalessEnum(enumName, schemaBundleId);
     }
 
+    @Override
     public abstract java.lang.String getEnumName();
 
     public abstract java.lang.String schemaBundleId();

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java

@@ -2697,8 +2697,8 @@ public void readChangeStreamAsync(
    * Executes a SQL Query and returns a ResultSet to iterate over the results. The returned
    * ResultSet instance is not threadsafe, it can only be used from single thread.
    *
-   * <p> The {@link BoundStatement} must be built from a {@link PreparedStatement} created using
-   * the same instance and app profile.
+   * <p>The {@link BoundStatement} must be built from a {@link PreparedStatement} created using the
+   * same instance and app profile.
    *
    * <p>Sample code:
    *
@@ -2719,9 +2719,11 @@ public void readChangeStreamAsync(
    *    } catch (RuntimeException e) {
    *        e.printStackTrace();
    *   }
+   * }
    * }</pre>
    *
-   * @see {@link PreparedStatement} & {@link BoundStatement} for query options.
+   * @see PreparedStatement for query options.
+   * @see BoundStatement for query options.
    */
   public ResultSet executeQuery(BoundStatement boundStatement) {
     boundStatement.assertUsingSameStub(stub);

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java

@@ -146,38 +146,34 @@ public static Builder newBuilderForEmulator(String hostname, int port) {
   }
 
   /**
-   * @deprecated OpenCensus support is deprecated and will be removed in a future version
-   * Enables OpenCensus metric aggregations.
-   *
-   * <p>This will register Bigtable client relevant {@link io.opencensus.stats.View}s. When coupled
-   * with an exporter, it allows users to monitor client behavior.
-   *
-   * <p>Please note that in addition to calling this method, the application must:
-   * <ul>
-   *   <li>Include openensus-impl dependency on the classpath
-   *   <li>Configure an exporter like opencensus-exporter-stats-stackdriver
-   * </ul>
-   *
-   * <p>Example usage for maven:
-   * <pre>{@code
-   *   <dependency>
-   *     <groupId>io.opencensus</groupId>
-   *     <artifactId>opencensus-impl</artifactId>
-   *     <version>${opencensus.version}</version>
-   *     <scope>runtime</scope>
-   *   </dependency>
-   *
-   *   <dependency>
-   *     <groupId>io.opencensus</groupId>
-   *     <artifactId>opencensus-exporter-stats-stackdriver</artifactId>
-   *     <version>${opencensus.version}</version>
-   *   </dependency>
-   * </pre>
+   * @deprecated OpenCensus support is deprecated and will be removed in a future version Enables
+   *     OpenCensus metric aggregations.
+   *     <p>This will register Bigtable client relevant {@link io.opencensus.stats.View}s. When
+   *     coupled with an exporter, it allows users to monitor client behavior.
+   *     <p>Please note that in addition to calling this method, the application must:
+   *     <ul>
+   *       <li>Include openensus-impl dependency on the classpath
+   *       <li>Configure an exporter like opencensus-exporter-stats-stackdriver
+   *     </ul>
+   *     <p>Example usage for maven:
+   *     <pre>{@code
+   * <dependency>
+   *   <groupId>io.opencensus</groupId>
+   *   <artifactId>opencensus-impl</artifactId>
+   *   <version>${opencensus.version}</version>
+   *   <scope>runtime</scope>
+   * </dependency>
    *
-   * Java:
-   * <pre>{@code
-   *   StackdriverStatsExporter.createAndRegister();
-   *   BigtableDataSettings.enableOpenCensusStats();
+   * <dependency>
+   *   <groupId>io.opencensus</groupId>
+   *   <artifactId>opencensus-exporter-stats-stackdriver</artifactId>
+   *   <version>${opencensus.version}</version>
+   * </dependency>
+   * }</pre>
+   *     Java:
+   *     <pre>{@code
+   * StackdriverStatsExporter.createAndRegister();
+   * BigtableDataSettings.enableOpenCensusStats();
    * }</pre>
    */
   @Deprecated

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/AbstractProtoStructReader.java

@@ -41,8 +41,10 @@ public abstract class AbstractProtoStructReader implements StructReader {
   abstract List<Value> values();
 
   // Force subclasses to override equals and hashcode. We need this for tests.
+  @Override
   public abstract boolean equals(Object other);
 
+  @Override
   public abstract int hashCode();
 
   /**

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/PreparedStatementImpl.java

@@ -20,7 +20,6 @@
 import com.google.api.core.InternalApi;
 import com.google.auto.value.AutoValue;
 import com.google.cloud.bigtable.data.v2.models.sql.BoundStatement;
-import com.google.cloud.bigtable.data.v2.models.sql.BoundStatement.Builder;
 import com.google.cloud.bigtable.data.v2.models.sql.PreparedStatement;
 import com.google.cloud.bigtable.data.v2.models.sql.SqlType;
 import com.google.cloud.bigtable.data.v2.stub.EnhancedBigtableStub;
@@ -76,7 +75,7 @@ public static PreparedStatement create(
 
   @Override
   public BoundStatement.Builder bind() {
-    return new Builder(this, paramTypes);
+    return new BoundStatement.Builder(this, paramTypes);
   }
 
   /**

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/RegexUtil.java

@@ -33,7 +33,7 @@
  */
 @InternalApi
 public final class RegexUtil {
-  private static final byte[] NULL_BYTES = "\\x00".getBytes();
+  private static final byte[] NULL_BYTES = {0};
 
   private RegexUtil() {}
 

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/opencensus/MetricsTracer.java

@@ -37,6 +37,7 @@
 import java.util.concurrent.CancellationException;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicLong;
 import javax.annotation.Nullable;
 
 class MetricsTracer extends BigtableTracer {
@@ -55,17 +56,15 @@ class MetricsTracer extends BigtableTracer {
   private final AtomicBoolean opFinished = new AtomicBoolean();
   private final Stopwatch operationTimer = Stopwatch.createStarted();
   private final Stopwatch firstResponsePerOpTimer = Stopwatch.createStarted();
-  private long operationResponseCount = 0;
 
   // Attempt level metrics
   private int attemptCount = 0;
   private Stopwatch attemptTimer;
-  private long attemptResponseCount = 0;
 
   private volatile int attempt = 0;
 
   private volatile boolean reportBatchingLatency = false;
-  private volatile long batchThrottledLatency = 0;
+  private final AtomicLong batchThrottledLatency = new AtomicLong(0);
   private MetadataExtractorInterceptor.SidebandData sidebandData;
 
   MetricsTracer(
@@ -145,7 +144,6 @@ public void attemptStarted(int attemptNumber) {
     attempt = attemptNumber;
     attemptCount++;
     attemptTimer = Stopwatch.createStarted();
-    attemptResponseCount = 0;
   }
 
   @Override
@@ -200,11 +198,11 @@ private void recordAttemptCompletion(@Nullable Throwable throwable) {
     }
 
     if (reportBatchingLatency) {
-      measures.put(RpcMeasureConstants.BIGTABLE_BATCH_THROTTLED_TIME, batchThrottledLatency);
+      measures.put(RpcMeasureConstants.BIGTABLE_BATCH_THROTTLED_TIME, batchThrottledLatency.get());
 
       // Reset batch throttling latency for next attempt. This can't be done in attemptStarted
       // because batching flow control will add batching latency before the attempt has started.
-      batchThrottledLatency = 0;
+      batchThrottledLatency.set(0);
     }
 
     // Patch the throwable until it's fixed in gax. When an attempt failed,
@@ -228,8 +226,6 @@ public void responseReceived() {
     if (firstResponsePerOpTimer.isRunning()) {
       firstResponsePerOpTimer.stop();
     }
-    attemptResponseCount++;
-    operationResponseCount++;
   }
 
   @Override
@@ -245,7 +241,7 @@ public void setSidebandData(MetadataExtractorInterceptor.SidebandData sidebandDa
   @Override
   public void batchRequestThrottled(long totalThrottledMs) {
     reportBatchingLatency = true;
-    batchThrottledLatency += totalThrottledMs;
+    batchThrottledLatency.addAndGet(totalThrottledMs);
   }
 
   private TagContextBuilder newTagCtxBuilder() {