Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit db5899b

Browse files
committed
remove legacy dependency
1 parent 4cbb0f2 commit db5899b

2 files changed

Lines changed: 10 additions & 20 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,11 @@ private BigtableTableAdminClient(
209209
this.projectId = projectId;
210210
this.instanceId = instanceId;
211211
this.stub = stub;
212-
this.baseClient = BigtableTableAdminClientV2.create(stub);
212+
this.baseClient =
213+
new BigtableTableAdminClientV2(
214+
stub,
215+
(com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable) stub.awaitConsistencyCallable(),
216+
stub.awaitOptimizeRestoredTableCallable());
213217
}
214218

215219
/** Gets the project ID of the instance whose tables this client manages. */

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientV2.java

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,8 @@
3535
import com.google.cloud.bigtable.admin.v2.models.ConsistencyRequest;
3636
import com.google.cloud.bigtable.admin.v2.models.OptimizeRestoredTableOperationToken;
3737
import com.google.cloud.bigtable.admin.v2.models.RestoredTableResult;
38-
import com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable;
3938
import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStub;
4039
import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStubSettings;
41-
import com.google.cloud.bigtable.admin.v2.stub.EnhancedBigtableTableAdminStub;
4240
import com.google.common.base.Strings;
4341
import com.google.longrunning.Operation;
4442
import com.google.protobuf.Empty;
@@ -58,7 +56,7 @@
5856
* generator cannot handle natively (e.g., chained Long Running Operations, Consistency Polling).
5957
*/
6058
public class BigtableTableAdminClientV2 extends BaseBigtableTableAdminClient {
61-
private final AwaitConsistencyCallable awaitConsistencyCallable;
59+
private final com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable awaitConsistencyCallable;
6260
private final OperationCallable<Void, Empty, OptimizeRestoredTableMetadata>
6361
optimizeRestoredTableOperationBaseCallable;
6462

@@ -80,15 +78,15 @@ protected BigtableTableAdminClientV2(BigtableTableAdminStub stub) {
8078
@com.google.common.annotations.VisibleForTesting
8179
BigtableTableAdminClientV2(
8280
BigtableTableAdminStub stub,
83-
AwaitConsistencyCallable awaitConsistencyCallable,
81+
com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable awaitConsistencyCallable,
8482
OperationCallable<Void, Empty, OptimizeRestoredTableMetadata>
8583
optimizeRestoredTableOperationBaseCallable) {
8684
super(stub);
8785
this.awaitConsistencyCallable = awaitConsistencyCallable;
8886
this.optimizeRestoredTableOperationBaseCallable = optimizeRestoredTableOperationBaseCallable;
8987
}
9088

91-
private AwaitConsistencyCallable createAwaitConsistencyCallable(
89+
private com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable createAwaitConsistencyCallable(
9290
BigtableTableAdminStubSettings settings) throws IOException {
9391
ClientContext clientContext = ClientContext.create(settings);
9492
// TODO(igorbernstein2): expose polling settings
@@ -104,7 +102,7 @@ private AwaitConsistencyCallable createAwaitConsistencyCallable(
104102
.setRpcTimeoutMultiplier(1.0)
105103
.build();
106104

107-
return AwaitConsistencyCallable.create(
105+
return com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable.create(
108106
getStub().generateConsistencyTokenCallable(),
109107
getStub().checkConsistencyCallable(),
110108
clientContext,
@@ -200,18 +198,6 @@ public static final BigtableTableAdminClientV2 create(BaseBigtableTableAdminSett
200198
return new BigtableTableAdminClientV2(settings);
201199
}
202200

203-
/** Constructs an instance of BigtableTableAdminClientV2 with the given stub. */
204-
public static final BigtableTableAdminClientV2 create(BigtableTableAdminStub stub) {
205-
if (stub instanceof EnhancedBigtableTableAdminStub) {
206-
EnhancedBigtableTableAdminStub enhancedStub = (EnhancedBigtableTableAdminStub) stub;
207-
return new BigtableTableAdminClientV2(
208-
stub,
209-
(AwaitConsistencyCallable) enhancedStub.awaitConsistencyCallable(),
210-
enhancedStub.awaitOptimizeRestoredTableCallable());
211-
}
212-
return new BigtableTableAdminClientV2(stub);
213-
}
214-
215201
/**
216202
* Awaits the completion of the "Optimize Restored Table" operation.
217203
*
@@ -330,7 +316,7 @@ private UnaryCallable<ConsistencyRequest, Void> getAwaitConsistencyCallable() {
330316
return awaitConsistencyCallable;
331317
}
332318
throw new IllegalStateException(
333-
"AwaitConsistencyCallable not initialized. BigtableTableAdminClientV2 must be "
319+
"com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable not initialized. BigtableTableAdminClientV2 must be "
334320
+ "initialized via settings to use this functionality.");
335321
}
336322

0 commit comments

Comments
 (0)