PR feedback

Author: jinseopkim0

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyRequest.java

@@ -74,13 +74,17 @@ public static ConsistencyRequest forDataBoost(String tableId) {
 
   @InternalApi
   public static ConsistencyRequest forReplicationFromTableName(String tableName) {
+    Preconditions.checkArgument(
+        TableName.isParsableFrom(tableName), "tableName must be a fully qualified table name");
     return new AutoValue_ConsistencyRequest(
         tableName, CheckConsistencyRequest.ModeCase.STANDARD_READ_REMOTE_WRITES, null, true);
   }
 
   @InternalApi
   public static ConsistencyRequest forReplicationFromTableName(
       String tableName, String consistencyToken) {
+    Preconditions.checkArgument(
+        TableName.isParsableFrom(tableName), "tableName must be a fully qualified table name");
     Preconditions.checkNotNull(consistencyToken, "consistencyToken must not be null");
 
     return new AutoValue_ConsistencyRequest(

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java

@@ -76,6 +76,16 @@ public static EnhancedBigtableTableAdminStub createEnhanced(
     return new EnhancedBigtableTableAdminStub(settings, ClientContext.create(settings), null);
   }
 
+  /**
+   * Creates an instance of {@link EnhancedBigtableTableAdminStub} using the provided settings.
+   * This variant is used by the legacy client stack which relies on short table IDs and
+   * requires a {@link TableAdminRequestContext} to construct fully qualified table names.
+   *
+   * @param settings The settings used to configure the stub.
+   * @param requestContext The context used to format short table IDs.
+   * @return A new instance of {@code EnhancedBigtableTableAdminStub}.
+   * @throws IOException If there are errors creating the underlying client context.
+   */
   public static EnhancedBigtableTableAdminStub createEnhanced(
       BigtableTableAdminStubSettings settings, TableAdminRequestContext requestContext)
       throws IOException {

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyRequestTest.java

@@ -138,4 +138,14 @@ public void testToGenerateTokenProtoFromTableName() {
 
     assertThat(generateRequest.getName()).isEqualTo(fullTableName);
   }
+
+  @Test(expected = IllegalArgumentException.class)
+  public void testForReplicationFromTableNameInvalid() {
+    ConsistencyRequest.forReplicationFromTableName(TABLE_ID);
+  }
+
+  @Test(expected = IllegalArgumentException.class)
+  public void testForReplicationFromTableNameWithTokenInvalid() {
+    ConsistencyRequest.forReplicationFromTableName(TABLE_ID, CONSISTENCY_TOKEN);
+  }
 }