Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: remove duplicated dependency management of generated protos - #2626

Closed
igorbernstein2 wants to merge 2 commits into
mainfrom
dupe-dep-mgt
Closed

chore: remove duplicated dependency management of generated protos#2626
igorbernstein2 wants to merge 2 commits into
mainfrom
dupe-dep-mgt

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

All of these versions are already set in google-cloud-bigtable-bom which is used by all of the artifacts already

Change-Id: I0e14e4c477d3b60e3635ec741b8294c2ad39c581

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

All of these versions are already set in google-cloud-bigtable-bom which is used by all of the artifacts already

Change-Id: I0e14e4c477d3b60e3635ec741b8294c2ad39c581
@igorbernstein2
igorbernstein2 requested review from a team July 14, 2025 20:31
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jul 14, 2025
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 14, 2025
Comment thread pom.xml
</dependency>
<!-- Test Deps in alphabetical order -->
<dependency>
<groupId>com.google.api.grpc</groupId>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the indent seems wrong?

Comment thread pom.xml
<artifactId>google-cloud-bigtable</artifactId>
<version>2.61.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigtable:current} -->
</dependency>
<!-- Test Deps in alphabetical order -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be moved to line 178?

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2025
@igorbernstein2
igorbernstein2 deleted the dupe-dep-mgt branch February 22, 2026 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants