This repository was archived by the owner on May 8, 2026. It is now read-only.
chore: remove duplicated dependency management of generated protos - #2626
Closed
igorbernstein2 wants to merge 2 commits into
Closed
chore: remove duplicated dependency management of generated protos#2626igorbernstein2 wants to merge 2 commits into
igorbernstein2 wants to merge 2 commits into
Conversation
All of these versions are already set in google-cloud-bigtable-bom which is used by all of the artifacts already Change-Id: I0e14e4c477d3b60e3635ec741b8294c2ad39c581
mutianf
reviewed
Jul 14, 2025
| </dependency> | ||
| <!-- Test Deps in alphabetical order --> | ||
| <dependency> | ||
| <groupId>com.google.api.grpc</groupId> |
Contributor
There was a problem hiding this comment.
hmm the indent seems wrong?
| <artifactId>google-cloud-bigtable</artifactId> | ||
| <version>2.61.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigtable:current} --> | ||
| </dependency> | ||
| <!-- Test Deps in alphabetical order --> |
Contributor
There was a problem hiding this comment.
this line should be moved to line 178?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these versions are already set in google-cloud-bigtable-bom which is used by all of the artifacts already
Change-Id: I0e14e4c477d3b60e3635ec741b8294c2ad39c581
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.