This repository was archived by the owner on May 8, 2026. It is now read-only.
feat: add port as a parameter for the bigtable emulator - #2633
Closed
andre-sampaio wants to merge 4 commits into
Closed
feat: add port as a parameter for the bigtable emulator#2633andre-sampaio wants to merge 4 commits into
andre-sampaio wants to merge 4 commits into
Conversation
andre-sampaio
added
kokoro:run
product-auto-label
Bot
added
the
api: bigtable
yoshi-kokoro
removed
the
kokoro:run
mutianf
reviewed
Jul 16, 2025
|
|
||
| /** Starts the emulator process and waits for it to be ready. */ | ||
| public synchronized void start() throws IOException, TimeoutException, InterruptedException { | ||
| public synchronized void start(int port) |
Contributor
There was a problem hiding this comment.
I think there are a few places that you need to update as well:
depending on how they're creating the emulator?
Contributor
There was a problem hiding this comment.
also wondering if we should pass in hostname:port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.