Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat(bigtable): add internal grpc subconnections metric and add outstanding rpcs to INTERNAL_VIEW #2700

Merged
sushanb merged 3 commits into from
Oct 31, 2025
Merged

feat(bigtable): add internal grpc subconnections metric and add outstanding rpcs to INTERNAL_VIEW #2700

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4eeb09
feat(bigtable): add internal grpc subconnections metric
sushanb Oct 29, 2025
8a3f877
feat(bigtable): add internal grpc subconnections metric
sushanb Oct 29, 2025
bdf3989
Fix
sushanb Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 69 additions & 10 deletions ...src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,28 @@ public class BuiltinMetricsConstants {
static final AttributeKey<String> TRANSPORT_ZONE = AttributeKey.stringKey("transport_zone");
static final AttributeKey<String> TRANSPORT_SUBZONE = AttributeKey.stringKey("transport_subzone");

// gRPC attribute keys
static final AttributeKey<String> GRPC_LB_BACKEND_SERVICE_KEY =
AttributeKey.stringKey("grpc_lb_backend_service");
static final AttributeKey<String> GRPC_DISCONNECT_ERROR_KEY =
AttributeKey.stringKey("grpc_disconnect_error");
static final AttributeKey<String> GRPC_LB_LOCALITY_KEY =
AttributeKey.stringKey("grpc_lb_locality");

@mutianf mutianf Oct 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

Suggested change
AttributeKey.stringKey("grpc_lb_locality");
AttributeKey.stringKey("grpc.lb.locality");

?

@sushanb sushanb Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with the format.

All these attributes go reformatting here.

java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java

Line 359 in d12b37d

String normalizedKey = attrKey.replace('.', '_');

static final AttributeKey<String> GRPC_TARGET_KEY = AttributeKey.stringKey("grpc_target");

@mutianf mutianf Oct 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

Suggested change
static final AttributeKey<String> GRPC_TARGET_KEY = AttributeKey.stringKey("grpc_target");
static final AttributeKey<String> GRPC_TARGET_KEY = AttributeKey.stringKey("grpc.target");

?

static final AttributeKey<String> GRPC_SECURITY_LEVEL_KEY =
AttributeKey.stringKey("grpc_security_level");
static final AttributeKey<String> GRPC_METHOD_KEY = AttributeKey.stringKey("grpc.method");
static final AttributeKey<String> GRPC_STATUS_KEY = AttributeKey.stringKey("grpc.status");
static final AttributeKey<String> GRPC_LB_RLS_DATA_PLANE_TARGET_KEY =
AttributeKey.stringKey("grpc.lb.rls.data_plane_target");
static final AttributeKey<String> GRPC_LB_PICK_RESULT_KEY =
AttributeKey.stringKey("grpc.lb.pick_result");
static final AttributeKey<String> GRPC_LB_RLS_SERVER_TARGET_KEY =
AttributeKey.stringKey("grpc.lb.rls.server_target");
static final AttributeKey<String> GRPC_XDS_SERVER_KEY = AttributeKey.stringKey("grpc.xds.server");
static final AttributeKey<String> GRPC_XDS_RESOURCE_TYPE_KEY =
AttributeKey.stringKey("grpc.xds.resource_type");

public static final String METER_NAME = "bigtable.googleapis.com/internal/client/";

// Metric names
Expand All @@ -77,31 +99,68 @@ public class BuiltinMetricsConstants {
ImmutableMap.<String, Set<String>>builder()
.put(
"grpc.client.attempt.duration",
ImmutableSet.of("grpc.lb.locality", "grpc.method", "grpc.target", "grpc.status"))
ImmutableSet.of(
GRPC_LB_LOCALITY_KEY.getKey(),
GRPC_METHOD_KEY.getKey(),
GRPC_TARGET_KEY.getKey(),
GRPC_STATUS_KEY.getKey()))
.put(
"grpc.lb.rls.default_target_picks",
ImmutableSet.of("grpc.lb.rls.data_plane_target", "grpc.lb.pick_result"))
ImmutableSet.of(
GRPC_LB_RLS_DATA_PLANE_TARGET_KEY.getKey(), GRPC_LB_PICK_RESULT_KEY.getKey()))
.put(
"grpc.lb.rls.target_picks",
ImmutableSet.of(
"grpc.target",
"grpc.lb.rls.server_target",
"grpc.lb.rls.data_plane_target",
"grpc.lb.pick_result"))
GRPC_TARGET_KEY.getKey(),
GRPC_LB_RLS_SERVER_TARGET_KEY.getKey(),
GRPC_LB_RLS_DATA_PLANE_TARGET_KEY.getKey(),
GRPC_LB_PICK_RESULT_KEY.getKey()))
.put(
"grpc.lb.rls.failed_picks",
ImmutableSet.of("grpc.target", "grpc.lb.rls.server_target"))
ImmutableSet.of(GRPC_TARGET_KEY.getKey(), GRPC_LB_RLS_SERVER_TARGET_KEY.getKey()))
// TODO: "grpc.xds_client.connected"
.put("grpc.xds_client.server_failure", ImmutableSet.of("grpc.target", "grpc.xds.server"))
.put(
"grpc.xds_client.server_failure",
ImmutableSet.of(GRPC_TARGET_KEY.getKey(), GRPC_XDS_SERVER_KEY.getKey()))
// TODO: "grpc.xds_client.resource_updates_valid",
.put(
"grpc.xds_client.resource_updates_invalid",
ImmutableSet.of("grpc.target", "grpc.xds.server", "grpc.xds.resource_type"))
ImmutableSet.of(
GRPC_TARGET_KEY.getKey(),
GRPC_XDS_SERVER_KEY.getKey(),
GRPC_XDS_RESOURCE_TYPE_KEY.getKey()))
// TODO: "grpc.xds_client.resources"
// gRPC subchannel metrics
.put(
"grpc.subchannel.disconnections",
ImmutableSet.of(
GRPC_LB_BACKEND_SERVICE_KEY.getKey(),
GRPC_DISCONNECT_ERROR_KEY.getKey(),
GRPC_LB_LOCALITY_KEY.getKey(),
GRPC_TARGET_KEY.getKey()))
.put(
"grpc.subchannel.connection_attempts_succeeded",
ImmutableSet.of(
GRPC_LB_BACKEND_SERVICE_KEY.getKey(),
GRPC_LB_LOCALITY_KEY.getKey(),
GRPC_TARGET_KEY.getKey()))
.put(
"grpc.subchannel.connection_attempts_failed",
ImmutableSet.of(
GRPC_LB_BACKEND_SERVICE_KEY.getKey(),
GRPC_LB_LOCALITY_KEY.getKey(),
GRPC_TARGET_KEY.getKey()))
.put(
"grpc.subchannel.open_connections",
ImmutableSet.of(
GRPC_LB_BACKEND_SERVICE_KEY.getKey(),
GRPC_LB_LOCALITY_KEY.getKey(),
GRPC_SECURITY_LEVEL_KEY.getKey(),
GRPC_TARGET_KEY.getKey()))
.build();

public static final Set<String> INTERNAL_METRICS =
ImmutableSet.of(PER_CONNECTION_ERROR_COUNT_NAME).stream()
ImmutableSet.of(PER_CONNECTION_ERROR_COUNT_NAME, OUTSTANDING_RPCS_PER_CHANNEL_NAME).stream()
.map(m -> METER_NAME + m)
.collect(ImmutableSet.toImmutableSet());
// End allow list of metrics that will be exported
Expand Down
Loading