This repository was archived by the owner on May 8, 2026. It is now read-only.
test: fix tests after junit5 introduction - #2842
Merged
Merged
Conversation
igorbernstein2
commented
Mar 13, 2026
igorbernstein2
commented
Contributor
- add deps for junit drivers for both junit4 & 5 to ensure that all tests run
- temporarily disable a broken test
- update all tests to disable metrics to reduce log spam
- update tests for connectivity & batching metrics to properly check attributes for client schema (it seems like the tests were written for table schema?)
- add Truth checks to BuiltinMetricsTestUtils to make easier to see what attributes are missing when the test fails
Change-Id: I07ec31eda18f13cdab34aaed7e55e5c08ea078df
product-auto-label
Bot
added
size: m
mutianf
approved these changes
Mar 13, 2026
igorbernstein2
added
automerge
jinseopkim0
approved these changes
Mar 13, 2026
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.