refactor: Merge BsonBinaryData into Blob

Author: wu-hui

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Blob.java

@@ -27,31 +27,67 @@ public final class Blob implements Serializable {
   private static final long serialVersionUID = 1441087101882481208L;
 
   private final ByteString byteString;
+  private final int subtype;
+  private final boolean isBson;
 
-  private Blob(ByteString byteString) {
+  private Blob(ByteString byteString, int subtype, boolean isBson) {
+    if (subtype < 0 || subtype > 255) {
+      throw new IllegalArgumentException(
+          "The subtype for Blob must be a value in the inclusive [0, 255] range.");
+    }
     this.byteString = byteString;
+    this.subtype = subtype;
+    this.isBson = isBson;
   }
 
   /**
-   * Creates a new Blob instance from the provided ByteString.
+   * Creates a new Blob instance from the provided ByteString. Defaults to subtype 0 and native
+   * representation.
    *
    * @param byteString The byteString to use for this Blob instance.
    * @return The new Blob instance
    */
   @Nonnull
   public static Blob fromByteString(@Nonnull ByteString byteString) {
-    return new Blob(byteString);
+    return new Blob(byteString, 0, false);
   }
 
   /**
    * Creates a new Blob instance from the provided bytes. Makes a copy of the bytes passed in.
+   * Defaults to subtype 0 and native representation.
    *
    * @param bytes The bytes to use for this Blob instance.
    * @return The new Blob instance
    */
   @Nonnull
   public static Blob fromBytes(@Nonnull byte[] bytes) {
-    return new Blob(ByteString.copyFrom(bytes));
+    return new Blob(ByteString.copyFrom(bytes), 0, false);
+  }
+
+  /**
+   * Creates a new Blob instance from the provided ByteString and subtype. Sets representation to
+   * BSON.
+   *
+   * @param subtype The subtype to use for this instance.
+   * @param byteString The byteString to use for this Blob instance.
+   * @return The new Blob instance
+   */
+  @Nonnull
+  public static Blob fromByteString(int subtype, @Nonnull ByteString byteString) {
+    return new Blob(byteString, subtype, true);
+  }
+
+  /**
+   * Creates a new Blob instance from the provided bytes and subtype. Makes a copy of the bytes
+   * passed in. Sets representation to BSON.
+   *
+   * @param subtype The subtype to use for this instance.
+   * @param bytes The bytes to use for this Blob instance.
+   * @return The new Blob instance
+   */
+  @Nonnull
+  public static Blob fromBytes(int subtype, @Nonnull byte[] bytes) {
+    return new Blob(ByteString.copyFrom(bytes), subtype, true);
   }
 
   /**
@@ -74,6 +110,24 @@ public byte[] toBytes() {
     return byteString.toByteArray();
   }
 
+  /**
+   * Returns the subtype of this binary data.
+   *
+   * @return The subtype of the binary data.
+   */
+  public int subtype() {
+    return this.subtype;
+  }
+
+  /**
+   * Returns whether this Blob represents a BSON binary data type.
+   *
+   * @return True if BSON representation, false if native representation.
+   */
+  public boolean isBson() {
+    return this.isBson;
+  }
+
   /**
    * Returns true if this Blob is equal to the provided object.
    *
@@ -89,11 +143,27 @@ public boolean equals(Object obj) {
       return false;
     }
     Blob blob = (Blob) obj;
-    return Objects.equals(byteString, blob.byteString);
+    return this.subtype == blob.subtype && Objects.equals(byteString, blob.byteString);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(byteString);
+    return Objects.hash(byteString, subtype);
+  }
+
+  com.google.firestore.v1.MapValue toProto() {
+    return UserDataConverter.encodeBsonBinaryData(subtype, byteString);
+  }
+
+  @Nonnull
+  @Override
+  public String toString() {
+    return "Blob{subtype="
+        + this.subtype
+        + ", isBson="
+        + this.isBson
+        + ", data="
+        + this.byteString.toString()
+        + "}";
   }
 }

google-cloud-firestore/src/main/java/com/google/cloud/firestore/BsonBinaryData.java

@@ -482,17 +482,7 @@ public BsonTimestamp getBsonTimestamp(@Nonnull String field) {
     return (BsonTimestamp) get(field);
   }
 
-  /**
-   * Returns the value of the field as a BsonBinaryData.
-   *
-   * @param field The path to the field.
-   * @throws RuntimeException if the value is not a BsonBinaryData.
-   * @return The value of the field.
-   */
-  @Nullable
-  public BsonBinaryData getBsonBinaryData(@Nonnull String field) {
-    return (BsonBinaryData) get(field);
-  }
+
 
   /**
    * Gets the reference to the document.

google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java

@@ -43,7 +43,6 @@ enum TypeOrder implements Comparable<TypeOrder> {
     BSON_TIMESTAMP,
     STRING,
     BLOB,
-    BSON_BINARY,
     REF,
     BSON_OBJECT_ID,
     GEO_POINT,
@@ -100,7 +99,7 @@ static TypeOrder fromMapValue(MapValue mapValue) {
       case BSON_TIMESTAMP:
         return TypeOrder.BSON_TIMESTAMP;
       case BSON_BINARY_DATA:
-        return TypeOrder.BSON_BINARY;
+        return TypeOrder.BLOB;
       case UNKNOWN:
       case NONE:
       default:
@@ -160,8 +159,7 @@ public int compare(@Nonnull Value left, @Nonnull Value right) {
         return compareBsonObjectId(left, right);
       case BSON_TIMESTAMP:
         return compareBsonTimestamp(left, right);
-      case BSON_BINARY:
-        return compareBsonBinary(left, right);
+
       default:
         throw new IllegalArgumentException("Cannot compare " + leftType);
     }
@@ -226,11 +224,25 @@ public static int compareUtf8Strings(String left, String right) {
   }
 
   private int compareBlobs(Value left, Value right) {
-    ByteString leftBytes = left.getBytesValue();
-    ByteString rightBytes = right.getBytesValue();
+    ByteString leftBytes = getEffectiveBytes(left);
+    ByteString rightBytes = getEffectiveBytes(right);
     return compareByteStrings(leftBytes, rightBytes);
   }
 
+  private static ByteString getEffectiveBytes(Value value) {
+    if (value.hasBytesValue()) {
+      return ByteString.copyFrom(new byte[] {0}).concat(value.getBytesValue());
+    }
+    if (value.hasMapValue() && UserDataConverter.isBsonBinaryData(value.getMapValue())) {
+      return value
+          .getMapValue()
+          .getFieldsMap()
+          .get(MapType.RESERVED_BSON_BINARY_KEY)
+          .getBytesValue();
+    }
+    throw new IllegalArgumentException("Cannot get effective bytes for non-blob value: " + value);
+  }
+
   static int compareByteStrings(ByteString leftBytes, ByteString rightBytes) {
     int size = Math.min(leftBytes.size(), rightBytes.size());
     for (int i = 0; i < size; i++) {
@@ -412,13 +424,7 @@ private int compareBsonTimestamp(Value left, Value right) {
     return secondsDiff != 0 ? secondsDiff : Long.compare(lhs.increment, rhs.increment);
   }
 
-  private int compareBsonBinary(Value left, Value right) {
-    ByteString lhs =
-        left.getMapValue().getFieldsMap().get(MapType.RESERVED_BSON_BINARY_KEY).getBytesValue();
-    ByteString rhs =
-        right.getMapValue().getFieldsMap().get(MapType.RESERVED_BSON_BINARY_KEY).getBytesValue();
-    return compareByteStrings(lhs, rhs);
-  }
+
 
   private boolean isNaN(Value value) {
     if (value.hasDoubleValue() && Double.isNaN(value.getDoubleValue())) {

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Order.java

@@ -19,7 +19,7 @@
 import com.google.api.core.InternalApi;
 import com.google.cloud.Timestamp;
 import com.google.cloud.firestore.Blob;
-import com.google.cloud.firestore.BsonBinaryData;
+
 import com.google.cloud.firestore.BsonObjectId;
 import com.google.cloud.firestore.BsonTimestamp;
 import com.google.cloud.firestore.Decimal128Value;
@@ -171,7 +171,7 @@ static <T> Object serialize(T o, DeserializeContext.ErrorPath path) {
         || o instanceof Decimal128Value
         || o instanceof BsonTimestamp
         || o instanceof BsonObjectId
-        || o instanceof BsonBinaryData
+
         || o instanceof GeoPoint
         || o instanceof Blob
         || o instanceof DocumentReference
@@ -346,8 +346,7 @@ private static <T> T deserializeToClass(Object o, Class<T> clazz, DeserializeCon
       return (T) convertBsonObjectId(o, context.errorPath);
     } else if (BsonTimestamp.class.isAssignableFrom(clazz)) {
       return (T) convertBsonTimestamp(o, context.errorPath);
-    } else if (BsonBinaryData.class.isAssignableFrom(clazz)) {
-      return (T) convertBsonBinaryData(o, context.errorPath);
+
     } else if (DocumentReference.class.isAssignableFrom(clazz)) {
       return (T) convertDocumentReference(o, context.errorPath);
     } else if (clazz.isArray()) {
@@ -686,16 +685,6 @@ private static BsonTimestamp convertBsonTimestamp(
     }
   }
 
-  private static BsonBinaryData convertBsonBinaryData(
-      Object o, DeserializeContext.ErrorPath errorPath) {
-    if (o instanceof BsonBinaryData) {
-      return (BsonBinaryData) o;
-    } else {
-      throw errorPath.deserializeError(
-          "Failed to convert value of type " + o.getClass().getName() + " to BsonBinaryData");
-    }
-  }
-
   private static DocumentReference convertDocumentReference(
       Object o, DeserializeContext.ErrorPath errorPath) {
     if (o instanceof DocumentReference) {