Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

ci: update hermetic generation workflow to use the latest image #2369

Closed
suztomo wants to merge 2 commits into from
Closed

ci: update hermetic generation workflow to use the latest image #2369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb082d
ci: update hermetic generation workflow to use the latest image
suztomo Apr 17, 2026
350ea1b
chore: generate libraries at Fri Apr 17 21:24:46 UTC 2026
cloud-java-bot Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/update_generation_config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ latest_version=$(get_latest_released_version "com.google.api" "gapic-generator-j
update_config "gapic_generator_version" "${latest_version}" "${generation_config}"

# Update composite action version to latest gapic-generator-java version
update_action "googleapis/sdk-platform-java/.github/scripts" \
update_action "googleapis/google-cloud-java/sdk-platform-java/.github/scripts" \
"${latest_version}" \
"${workflow}"

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/hermetic_library_generation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- uses: googleapis/google-cloud-java/sdk-platform-java/.github/scripts@v1.85.0
if: env.SHOULD_RUN == 'true'
with:
image_tag: latest

@blakeli0 blakeli0 Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to point the image to latest. It was designed to use a release tag to prevent accidental changes.
I assume this is only for testing and will be removed before merging?

@suztomo suztomo Apr 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

base_ref: ${{ github.base_ref }}
head_ref: ${{ github.head_ref }}
token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}
Loading