Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

Commit 0098131

Browse files
committed
chore: Add junit ignore deps for dependency plugin
1 parent 77a0367 commit 0098131

3 files changed

Lines changed: 21 additions & 7 deletions

File tree

google-cloud-logging/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,13 @@
108108
</dependency>
109109

110110
<!-- Test dependencies -->
111+
<!-- JUnit 4.x is still needed as the gapic-generator still generates tests with it -->
112+
<!-- Remove once the gapic-generator is able to generate JUnit 5.x tests -->
113+
<dependency>
114+
<groupId>junit</groupId>
115+
<artifactId>junit</artifactId>
116+
<scope>test</scope>
117+
</dependency>
111118
<dependency>
112119
<groupId>org.junit.jupiter</groupId>
113120
<artifactId>junit-jupiter-api</artifactId>
@@ -123,6 +130,8 @@
123130
<artifactId>junit-jupiter-params</artifactId>
124131
<scope>test</scope>
125132
</dependency>
133+
<!-- The generated tests from gapic-generator are still generated with JUnit4. -->
134+
<!-- Remove once they are migrated to JUnit 5.x+ -->
126135
<dependency>
127136
<groupId>org.junit.vintage</groupId>
128137
<artifactId>junit-vintage-engine</artifactId>

google-cloud-logging/src/test/java/com/google/cloud/logging/InstrumentationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,4 +149,4 @@ private static void verifyEntries(
149149
assertEquals(0, names.size());
150150
assertEquals(0, versions.size());
151151
}
152-
}
152+
}

pom.xml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,10 @@
102102
</dependency>
103103

104104
<dependency>
105-
<groupId>org.junit</groupId>
106-
<artifactId>junit-bom</artifactId>
107-
<version>5.10.1</version>
108-
<type>pom</type>
109-
<scope>import</scope>
105+
<groupId>junit</groupId>
106+
<artifactId>junit</artifactId>
107+
<version>4.13.2</version>
108+
<scope>test</scope>
110109
</dependency>
111110
<dependency>
112111
<groupId>org.easymock</groupId>
@@ -195,7 +194,13 @@
195194
<groupId>org.apache.maven.plugins</groupId>
196195
<artifactId>maven-dependency-plugin</artifactId>
197196
<configuration>
198-
<ignoredUnusedDeclaredDependencies>org.objenesis:objenesis</ignoredUnusedDeclaredDependencies>
197+
<ignoredUnusedDeclaredDependencies>
198+
<ignoredUnusedDeclaredDependency>org.objenesis:objenesis</ignoredUnusedDeclaredDependency>
199+
<!-- maven-dependency-plugin cannot detect the runtime usage of junit-jupiter-engine for executing JUnit 5+ tests. -->
200+
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
201+
<!-- maven-dependency-plugin cannot detect the runtime usage of junit-vintage-engine for executing JUnit 4.x tests. -->
202+
<ignoredUnusedDeclaredDependency>org.junit.vintage:junit-vintage-engine</ignoredUnusedDeclaredDependency>
203+
</ignoredUnusedDeclaredDependencies>
199204
</configuration>
200205
</plugin>
201206
</plugins>

0 commit comments

Comments
 (0)