feat: add support for Pub/Sub emulator configuration#399
feat: add support for Pub/Sub emulator configuration#399matt-kwong merged 7 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Introduced a new configuration option cps.useEmulator to allow users to switch between the production service and the Pub/Sub emulator. Updated the README to document this feature and modified the relevant classes to handle the emulator endpoint based on the configuration. Added a test to verify the emulator configuration is correctly defined and parsed.
|
Hi @matt-kwong, could you help me review this one? I have been using in for our local development successfully, the connector is also used in prod, no issues neither. Thank you! |
matt-kwong
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback from the other PR!
Aside from my formatting comments, could you also address the build and formatting errors in the PR checks?
Hi @matt-kwong, all comments has been addressed |
Add Pub/Sub Emulator Support
Implements support for the Google Cloud Pub/Sub emulator based on feedback from #381. This PR addresses the feature request in #290 with a cleaner boolean configuration approach.
Changes
cps.useEmulatorconfig (defaults tofalse)PUBSUB_EMULATOR_HOSTenvironment variablecps.endpointif env var not setUsage
All tests pass (81 tests, 0 failures). Fixes #290 ☕️