Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

Commit 0350d8f

Browse files
committed
add minFailedCalls parameter to createFallbackChannelOptions
1 parent 1140d7d commit 0350d8f

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ public <ReqT, RespT> ClientCall<ReqT, RespT> interceptCall(
438438
return new FallbackChannelBuilder(
439439
primaryGcpBuilder,
440440
fallbackGcpBuilder,
441-
createFallbackChannelOptions(fallbackTelemetry));
441+
createFallbackChannelOptions(fallbackTelemetry, 1));
442442
});
443443
}
444444

@@ -613,11 +613,11 @@ public <RequestT, ResponseT> UnaryCallable<RequestT, ResponseT> createUnaryCalla
613613

614614
@VisibleForTesting
615615
GcpFallbackChannelOptions createFallbackChannelOptions(
616-
GcpFallbackOpenTelemetry fallbackTelemetry) {
616+
GcpFallbackOpenTelemetry fallbackTelemetry, int minFailedCalls) {
617617
return GcpFallbackChannelOptions.newBuilder()
618618
.setPrimaryChannelName("directpath")
619619
.setFallbackChannelName("cloudpath")
620-
.setMinFailedCalls(1)
620+
.setMinFailedCalls(minFailedCalls)
621621
.setGcpFallbackOpenTelemetry(fallbackTelemetry)
622622
.build();
623623
}

google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpcTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -905,11 +905,12 @@ public TestableGapicSpannerRpc(SpannerOptions options) {
905905

906906
@Override
907907
GcpFallbackChannelOptions createFallbackChannelOptions(
908-
GcpFallbackOpenTelemetry fallbackTelemetry) {
908+
GcpFallbackOpenTelemetry fallbackTelemetry, int minFailedCalls) {
909909
// Override default 1-minute period to 10ms for instant testing
910910
return GcpFallbackChannelOptions.newBuilder()
911911
.setPrimaryChannelName("directpath")
912912
.setFallbackChannelName("cloudpath")
913+
.setMinFailedCalls(10)
913914
.setPeriod(Duration.ofMillis(10))
914915
.setGcpFallbackOpenTelemetry(fallbackTelemetry)
915916
.build();
@@ -973,7 +974,7 @@ public TestableGapicSpannerRpcWithLowerMinFailedCalls(SpannerOptions options) {
973974

974975
@Override
975976
GcpFallbackChannelOptions createFallbackChannelOptions(
976-
GcpFallbackOpenTelemetry fallbackTelemetry) {
977+
GcpFallbackOpenTelemetry fallbackTelemetry, int minFailedCalls) {
977978
// Override default 1-minute period to 10ms for instant testing
978979
return GcpFallbackChannelOptions.newBuilder()
979980
.setPrimaryChannelName("directpath")

0 commit comments

Comments
 (0)