Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

Commit a328488

Browse files
committed
Enable optional labels
1 parent c14fdb8 commit a328488

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsConstant.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,23 @@ public class BuiltInMetricsConstant {
6868
.map(m -> METER_NAME + '/' + m)
6969
.collect(Collectors.toSet());
7070

71+
// The following attributes are optional and need to be enabled explicitly.
72+
public static final String GRPC_LB_BACKEND_SERVICE_ATTRIBUTE = "grpc.lb.backend_service";
73+
public static final String GRPC_LB_LOCALITY_ATTRIBUTE = "grpc.lb.locality";
74+
public static final String GRPC_DISCONNECT_ERROR_ATTRIBUTE = "grpc.disconnect_error";
75+
7176
static final Set<String> GRPC_LB_RLS_ATTRIBUTES =
7277
ImmutableSet.of("grpc.lb.rls.data_plane_target", "grpc.lb.pick_result");
7378
static final Set<String> GRPC_CLIENT_ATTEMPT_STARTED_ATTRIBUTES =
7479
ImmutableSet.of("grpc.method", "grpc.target");
7580
static final Set<String> GRPC_SUBCHANNEL_DEFAULT_ATTRIBUTES =
76-
ImmutableSet.of("grpc.target", "grpc.lb.locality", "grpc.lb.backend_service");
81+
ImmutableSet.of("grpc.target", GRPC_LB_BACKEND_SERVICE_ATTRIBUTE, GRPC_LB_LOCALITY_ATTRIBUTE);
7782
static final Set<String> GRPC_SUBCHANNEL_DISCONNECTION_ATTRIBUTES =
7883
ImmutableSet.of(
79-
"grpc.target", "grpc.lb.locality", "grpc.lb.backend_service", "grpc.disconnect_error");
84+
"grpc.target",
85+
GRPC_LB_BACKEND_SERVICE_ATTRIBUTE,
86+
GRPC_LB_LOCALITY_ATTRIBUTE,
87+
GRPC_DISCONNECT_ERROR_ATTRIBUTE);
8088
static final Set<String> GRPC_XDS_CLIENT_RESOURCE_UPDATE_ATTRIBUTES =
8189
ImmutableSet.of("grpc.xds.resource_type");
8290

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsProvider.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,9 @@ void enableGrpcMetrics(
150150
.enableMetrics(BuiltInMetricsConstant.GRPC_METRICS_TO_ENABLE)
151151
// Disable gRPCs default metrics as they are not needed for Spanner.
152152
.disableMetrics(BuiltInMetricsConstant.GRPC_METRICS_ENABLED_BY_DEFAULT)
153+
.addOptionalLabel(BuiltInMetricsConstant.GRPC_LB_BACKEND_SERVICE_ATTRIBUTE)
154+
.addOptionalLabel(BuiltInMetricsConstant.GRPC_LB_LOCALITY_ATTRIBUTE)
155+
.addOptionalLabel(BuiltInMetricsConstant.GRPC_DISCONNECT_ERROR_ATTRIBUTE)
153156
.build();
154157
ApiFunction<ManagedChannelBuilder, ManagedChannelBuilder> channelConfigurator =
155158
channelProviderBuilder.getChannelConfigurator();

0 commit comments

Comments
 (0)