Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

chore: Improve traces - #4150

Merged
gcf-merge-on-green[bot] merged 12 commits into
mainfrom
traces_improve
Nov 3, 2025
Merged

chore: Improve traces#4150
gcf-merge-on-green[bot] merged 12 commits into
mainfrom
traces_improve

Conversation

@surbhigarg92

@surbhigarg92 surbhigarg92 commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

This PR does below

  • Add request-id as span attribute
  • Add common attributes for all the Spans

@surbhigarg92
surbhigarg92 requested review from a team October 8, 2025 08:52
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Oct 8, 2025
sakthivelmanii
sakthivelmanii previously approved these changes Oct 14, 2025
View reviewed changes
@rahul2393 rahul2393 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 23, 2025
@gcf-merge-on-green

gcf-merge-on-green Bot commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2025
@surbhigarg92 surbhigarg92 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 29, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2025
@gcf-merge-on-green

gcf-merge-on-green Bot commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 30, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2025
@surbhigarg92 surbhigarg92 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2025
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 9cdba74 into main Nov 3, 2025
57 of 60 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2025
@gcf-merge-on-green
gcf-merge-on-green Bot deleted the traces_improve branch November 3, 2025 05:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@rahul2393 rahul2393 rahul2393 approved these changes
@sakthivelmanii sakthivelmanii sakthivelmanii left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@surbhigarg92 @rahul2393 @sakthivelmanii @yoshi-kokoro @cloud-java-bot