feat: next release is v6.105.0-rc1 - #4259
Conversation
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
#4252) * fix: Refine connecitivity metrics to capture RPCs with no response headers * test fix
Most transactions that exceed the mutation limit for an atomic transaction will fail with the error "The transaction contains too many mutations.". However, it is also possible that the transaction fails with the more generic error message "Transaction resource limits exceeded". This error did not trigger a retry of the statement using a PDML transaction. Fixes #4253
Summary of ChangesHello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on preparing the project for its next release, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for the v6.105.0-rc1 release. It includes version bumps for all modules, configuration for release-please, and incorporates two main features from the main branch:
- Support for a new "Transaction resource limits exceeded" error message, treating it as a transaction mutation limit exceeded error.
- A significant refactoring of
HeaderInterceptorto improve readability and maintainability by moving metric recording logic fromonHeaderstoonClose.
The changes are generally good, especially the test parameterization for the new error message and the structural improvements in HeaderInterceptor. However, I've found a critical race condition in the refactored HeaderInterceptor where call-specific state is stored in instance fields of what is likely a shared interceptor, which could lead to incorrect metrics under concurrent load. I've also pointed out a minor formatting issue in an XML configuration file.
| private Float gfeLatency; | ||
| private Float afeLatency; |
There was a problem hiding this comment.
These fields introduce a potential race condition. HeaderInterceptor is typically a singleton shared across all gRPC calls on a channel. Storing call-specific state like gfeLatency and afeLatency as instance fields can lead to incorrect metric values under concurrent load, as one call might overwrite the values of another.
To fix this, this state should be stored within the scope of a single call. A good place would be as fields within the SimpleForwardingClientCallListener instance created for each call. These values can then be passed as parameters to the record... methods.
| <differenceType>7002</differenceType> | ||
| <className>com/google/cloud/spanner/CompositeTracer</className> | ||
| <method>void recordGFELatency(java.lang.Float)</method> | ||
| </difference><difference> |
Includes sync with main, including commits 7b49412 and c735d42