Skip to content
This repository was archived by the owner on Jun 2, 2026. It is now read-only.

feat: implement CloudStorageFileSystemProvider.move method using the moveBlob API - #1610

Merged
maroth96 merged 1 commit into
googleapis:mainfrom
maroth96:main
Jul 9, 2025
Merged

feat: implement CloudStorageFileSystemProvider.move method using the moveBlob API#1610
maroth96 merged 1 commit into
googleapis:mainfrom
maroth96:main

Conversation

@maroth96

@maroth96 maroth96 commented Jun 21, 2025

Copy link
Copy Markdown
Contributor

Fixes #1609

@maroth96
maroth96 requested a review from a team June 21, 2025 01:32
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage-nio API. labels Jun 21, 2025
@maroth96 maroth96 changed the title Implement CloudStorageFileSystemProvider.move method using the moveBl… Implement CloudStorageFileSystemProvider.move method using the moveBlob API Jun 21, 2025
@BenWhitehead BenWhitehead changed the title Implement CloudStorageFileSystemProvider.move method using the moveBlob API feat: update CloudStorageFileSystemProvider.move method to use the moveBlob API instead of rewrite+delete Jun 26, 2025
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2025
@BenWhitehead

BenWhitehead commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Can you run mvn com.spotify.fmt:fmt-maven-plugin:format in a shell with java 17+ to format the code? This will get the lint check passing.

@BenWhitehead

BenWhitehead commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

One the lint build is passing, I can do final approval and we can get this merged.

@maroth96 maroth96 changed the title feat: update CloudStorageFileSystemProvider.move method to use the moveBlob API instead of rewrite+delete Implement CloudStorageFileSystemProvider.move method using the moveBlob API Jun 26, 2025
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
@maroth96 maroth96 changed the title Implement CloudStorageFileSystemProvider.move method using the moveBlob API feat: implement CloudStorageFileSystemProvider.move method using the moveBlob API Jun 27, 2025
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2025
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2025
@maroth96
maroth96 merged commit bdd785e into googleapis:main Jul 9, 2025
19 of 20 checks passed
@release-please release-please Bot mentioned this pull request Jul 9, 2025
Merged
@release-please release-please Bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@BenWhitehead BenWhitehead BenWhitehead approved these changes
@cojenco cojenco cojenco approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage-nio API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CloudStorageFileSystemProvider.move should be implemented using the moveBlob API

4 participants

@maroth96 @BenWhitehead @cojenco @yoshi-kokoro